Skip to content

Conversation

@NelsonDaniel
Copy link
Contributor

@NelsonDaniel NelsonDaniel commented Aug 24, 2018

Description

Added storage data plane test to netstandard automation.

Checklist

@NelsonDaniel
Copy link
Contributor Author

NelsonDaniel commented Aug 24, 2018

Issue #6930

@maddieclayton
Copy link
Contributor

@NelsonDaniel Is this ready for one of us to take a look at?

@NelsonDaniel
Copy link
Contributor Author

@maddieclayton yes, it is ready for one of you to take a look at.

@maddieclayton maddieclayton assigned markcowl and blueww and unassigned NelsonDaniel Aug 27, 2018
@maddieclayton
Copy link
Contributor

@blueww @markcowl Can you take a look at this PR?

blueww
blueww previously approved these changes Aug 28, 2018
@blueww
Copy link
Member

blueww commented Aug 28, 2018

Generally looks good to me, and I have approved it.
I will add more cases as new dataplane functions added.

Only one minor concern: I see we will create a storage account for each cases. This looks a little time consuming. Can we share the storage account for all cases?

@NelsonDaniel
Copy link
Contributor Author

NelsonDaniel commented Aug 29, 2018

@blueww thank you for the feedback. Certainty, that is something I can look into. However, I’m currently doing some training and I will be blocked until the first week of September.

@NelsonDaniel
Copy link
Contributor Author

@blueww I just added additional logic to the tests (i.e. testBlob and testCommon) so there is a wait time to have the service updates reflected before an assertion is performed.

@blueww
Copy link
Member

blueww commented Sep 7, 2018

approve with a minor comment.

@NelsonDaniel
Copy link
Contributor Author

@markcowl This PR is ready to merge.

@markcowl markcowl merged commit 5ffc2e1 into Azure:preview Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants