Skip to content

Conversation

@maddieclayton
Copy link
Contributor

Description

Checklist

cormacpayne
cormacpayne previously approved these changes Nov 7, 2018
Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maddieclayton LGTM, but if you have time, I think it would be nice to update the help files for the cmdlets returning the affected types and make sure the output in the examples now match the new output (if it changed)

@cormacpayne cormacpayne removed their assignment Nov 7, 2018
@maddieclayton
Copy link
Contributor Author

This is just waiting for an approval and for common to be published

cormacpayne
cormacpayne previously approved these changes Nov 12, 2018
Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the common code changes are published

<package id="Microsoft.Azure.Common.Dependencies" version="1.0.0" targetFramework="net452" />
<package id="Microsoft.Azure.PowerShell.Authentication.Abstractions" version="1.1.7-preview" targetFramework="net452" />
<package id="Microsoft.Azure.PowerShell.Common" version="1.1.7-preview" targetFramework="net452" />
<package id="Microsoft.Azure.PowerShell.Authentication.Abstractions" version="1.0.217-preview" targetFramework="net452" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to republish the runtime, update these versions, and remove the localfeed dlls

@markcowl markcowl merged commit 5112f74 into Azure:preview Nov 13, 2018
@maddieclayton maddieclayton deleted the profileformat branch November 14, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants