-
Notifications
You must be signed in to change notification settings - Fork 4.1k
ESRP codesign master branch #8170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESRP codesign master branch #8170
Conversation
| <PublishDirectory>$(LibrarySourceFolder)\Publish</PublishDirectory> | ||
| <Configuration Condition=" '$(Configuration)' != 'Release'">Debug</Configuration> | ||
| <CodeSign Condition=" '$(CodeSign)' == '' ">false</CodeSign> | ||
| <CodeSign>false</CodeSign> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in the PR below, this needs to be conditional so we can sign bits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get the comment. To change the default CodeSign property value we can use /p:CodeSign=true switch.
Experiment
Targets file DoSomething.targets content:
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Action" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<CodeSigh>false</CodeSigh>
</PropertyGroup>
<Target Name="Action">
<!-- This is a built-in task -->
<Message Text="CodeSigh value is: $(CodeSigh)" />
</Target>
</Project>
Show property CodeSigh default value:
E:\temp>msbuild DoSomething.targets /t:Action
Microsoft (R) Build Engine version 15.8.169+g1ccb72aefa for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.
Build started 12/18/2018 8:30:37 PM.
Project "E:\temp\DoSomething.targets" on node 1 (Action target(s)).
Action:
CodeSigh value is: false
Done Building Project "E:\temp\DoSomething.targets" (Action target(s)).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:00.05
Change property CodeSigh value to true:
E:\temp>msbuild DoSomething.targets /t:Action /p:CodeSigh=true
Microsoft (R) Build Engine version 15.8.169+g1ccb72aefa for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.
Build started 12/18/2018 8:33:20 PM.
Project "E:\temp\DoSomething.targets" on node 1 (Action target(s)).
Action:
CodeSigh value is: true
Done Building Project "E:\temp\DoSomething.targets" (Action target(s)).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:00.05
|
Closing in favor of #8193 |
No description provided.