Skip to content

Conversation

@vladimir-shcherbakov
Copy link
Contributor

No description provided.

<PublishDirectory>$(LibrarySourceFolder)\Publish</PublishDirectory>
<Configuration Condition=" '$(Configuration)' != 'Release'">Debug</Configuration>
<CodeSign Condition=" '$(CodeSign)' == '' ">false</CodeSign>
<CodeSign>false</CodeSign>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in the PR below, this needs to be conditional so we can sign bits

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the comment. To change the default CodeSign property value we can use /p:CodeSign=true switch.

Experiment

Targets file DoSomething.targets content:

<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Action" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

    <PropertyGroup>
        <CodeSigh>false</CodeSigh>
    </PropertyGroup>

    <Target Name="Action">
        <!-- This is a built-in task -->
        <Message Text="CodeSigh value is: $(CodeSigh)" />
    </Target>
</Project>

Show property CodeSigh default value:

E:\temp>msbuild DoSomething.targets /t:Action
Microsoft (R) Build Engine version 15.8.169+g1ccb72aefa for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 12/18/2018 8:30:37 PM.
Project "E:\temp\DoSomething.targets" on node 1 (Action target(s)).
Action:
  CodeSigh value is: false
Done Building Project "E:\temp\DoSomething.targets" (Action target(s)).


Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:00.05

Change property CodeSigh value to true:

E:\temp>msbuild DoSomething.targets /t:Action /p:CodeSigh=true
Microsoft (R) Build Engine version 15.8.169+g1ccb72aefa for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 12/18/2018 8:33:20 PM.
Project "E:\temp\DoSomething.targets" on node 1 (Action target(s)).
Action:
  CodeSigh value is: true
Done Building Project "E:\temp\DoSomething.targets" (Action target(s)).


Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:00.05

@markcowl
Copy link
Member

@markcowl
Copy link
Member

@markcowl
Copy link
Member

@markcowl
Copy link
Member

Closing in favor of #8193

@markcowl markcowl closed this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants