ESRP signing for master and fix help check #8193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
MiYanni
previously requested changes
Dec 20, 2018
CodeSign.targets
Outdated
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
|
|
||
| <UsingTask TaskName="ESRPSignTask" AssemblyFile="$(CISignRepoPath)\tools\sdkbuildtools\tasks\MS.Az.Sdk.OnPremise.Build.Tasks.dll" /> |
Contributor
There was a problem hiding this comment.
Any reason this file is using tabs instead of spaces?
tools/RemoveCodeSignArtifacts.ps1
Outdated
|
|
||
| Write-Output "Under the'$Path' folder" | ||
|
|
||
| "Signed","Unsigned" | ForEach-Object { |
Contributor
There was a problem hiding this comment.
If this script is basically just removing 2 consistently-named folders, please do this instead in the build.proj:
<Exec Command="$(PowerShellCoreCommandPrefix) "Get-ChildItem -Path $(ArtifactsDirectory) -Recurse -Include 'Signed','Unsigned' | Remove-Item -Recurse -Force -Confirm:$false -ErrorAction Ignore"" ContinueOnError="WarnAndContinue" IgnoreExitCode="true" />Then, we don't need to maintain yet another script.
markcowl
dismissed
MiYanni’s stale review
need to move to ESRP ASAP, please file issues or fix later
Contributor
Member
Author
MiYanni
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdplatyPSmodule