ignore result of function to compile on G++ 5#2784
Conversation
vhvb1989
requested review from
RickWinter,
ahsonkhan,
antkmsft and
gearama
as code owners
|
/azp run cpp - core |
|
/azp run cpp - keyvault |
|
/azp run cpp - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run cpp - storage |
|
/azp run cpp - keyvault |
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run cpp - core |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run cpp - storage |
|
/azp run cpp - keyvault |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
| BIO_set_flags(bio, BIO_FLAGS_BASE64_NO_NL); | ||
| BIO_write(bio, data.data(), static_cast<int>(data.size())); | ||
| BIO_flush(bio); | ||
| (void)BIO_flush(bio); |
There was a problem hiding this comment.
This return shouldn't be removed. We need to check the return codes and act accordingly. I've opened a new issue to remove this dependency all out.
#2790
There was a problem hiding this comment.
yeah, I kind of remember this was mentioned before. I think @ahsonkhan moved this from storage to core and would be eventually be replaced for the base64 implementation that @antkmsft wrote for C99. If that's still the plan, the change could be targeted for Sep release maybe.
|
Public pipeline g++-5 : Internal pipelines also building with g++ with tests |
2 participants
fixes: #2785