Skip to content

Conversation

@cochi2
Copy link
Contributor

@cochi2 cochi2 commented Aug 9, 2022

Fixing the naming of PlayAll to PlayToAll to match .Net version.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@cochi2 cochi2 requested a review from juntuchen-msft August 9, 2022 23:23
@ghost ghost added the Communication label Aug 9, 2022
@cochi2 cochi2 merged commit c9f72f8 into feature/communication-InteractionController Aug 9, 2022
@cochi2 cochi2 deleted the fmorales/playtoall branch August 9, 2022 23:23
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-callingserver

mikeharder pushed a commit to mikeharder/azure-sdk-for-java that referenced this pull request Aug 16, 2022
* Checking in ServerCalling V3 code as it is now named InteractionController

* Moved actions in callConnection into serverClient and make callConnection a POCO

* added listParticipants

* bug fixing

* updated the version to beta6

* Added Media team's SDK

* fixed some checkstyle issues

* Adding Content Capabilities (Azure#29721)

* Adding Recording Operations (Azure#29737)

* Polished the code to meet Azure SDK guidelines. Changes are for meeting the guideline and fix errors and warnings during the build. Now the project can be built

* Added error handling

* updated README.md

* deleted callConnectionAsync~

* This is the commit for easy testing.

* Fixing checkystyle issue

* updated SDK

* Updated SDK with review feedback - part 1

* SDK update - part 2

* CallRecording/CallMedia changes (Azure#30062)

* Moving ProgressReporter to azure.core

* Using PlaySource instead of PlaySourceType

* Fixing RecordingResponse

* Adding StartRecordingResponse proxy

* Renaming StartRecordingResponse to the right RecordingStatusResponse

* Finishing to clean the different errors

* cleaning

* Fixing Proxy

* Fixing some checkstyle bugs

* Moving ContentClient to CallConnection. Changing PlaySource for FileSource

* Delete returns Void

* PlaySource instead of FileSource

* Adding DownloadToFileOptions. Fixing Play. Fixing Recording.

* Fixed optional params

* Fixing ParallelDownloadsOptions

* Fixing javadoc

* Fixing fluent options

* event handling

* Adding CancelAllMediaOperations methods (Azure#30063)

* events update

* event update

* Added configuration for testing

* resolved some mvn deploy issues

* Adding unit testing for Recording/Media operations (Azure#30101)

* Adding DownloadContent unit tests

* Adding DownloadContentLiveTests

* Adding DownloadContentAsyncLiveTests

* Adding Delete tests

* Adding CallMedia unit tests

* Adding Recording unit tests

* Refactoring Recording Tests

* deleted internal events as they are not used

* Added event handler

* Adding Play Options (Azure#30108)

Adding a Play Options object that includes the new operationContext string optional parameter for PlayRequest.

* Updated event handler

* updated version for deploying

* bug fixes

* changed package naming

* Removing context from Async methods. (Azure#30264)

* Initial commit

* Checkstyle fix

* Changed exception handling

* changed the version

* fixed versioning pipeline issue

* fixed some pipeline building issues

* Updated changelog

* Sync communication.common back to the main branch

* updated client builder as pma updated

* updated unit tests to adapt builder changes

* Fixing tests (Azure#30329)

* change the version back due to previous typo

* Fixing the naming of PlayToAll (Azure#30369)

* updated sdk according to github feedback

* removed AcsEventType as discussed

* updated versioning

* removed nextLink in ListPartcipantResponse as it is not supported now

* updated SDK according to feedback on github draft PR

* removed eventgrid events support from the eventParser

* Added some unit tests, also fixed some bugs got catched during running unit tests

* Added more unit tests

* Adding Recording/Play events. (Azure#30422)

* Updating Swagger

* Adding Recording/Play events

* Fixing recording status

* Fixing name of Recording state event

* Fixing naming for RecordingStatus all over the project

* Making build to succeed

* Adding RecordingStateChanged tests

* Adding Play Test

* Updating swagger

* Adding Play Events tests

* Adding Live Tests for Recording use cases (Azure#30452)

* Adding Recording Live Test

* Adding Async tests for Recording

* Renaming to CallAutomation

* Adding Media Live Test

* Adding Media Async Live Test

* Fixing exceptions on tests

* Not doing Play tests

* Updating Swagger

* Adding Recording/Play events

* Fixing recording status

* Fixing name of Recording state event

* Fixing naming for RecordingStatus all over the project

* Making build to succeed

* Adding RecordingStateChanged tests

* Adding Play Test

* Updating swagger

* Adding Play Events tests

* Merging all updates

* Add channel affinity to recording (Azure#30487)

* Add channel affinity to recording

* Fix bug

Co-authored-by: Franko Morales <67804607+cochi2@users.noreply.github.com>
Co-authored-by: williamzhao87 <williamzhao87@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants