Skip to content

API changes for HttpLogOptions#42138

Merged
alzimmermsft merged 9 commits into
Azure:mainfrom
alzimmermsft:AzCore_AddHttpHeaderNameApisToHttpLogOptions
Oct 17, 2024
Merged

API changes for HttpLogOptions#42138
alzimmermsft merged 9 commits into
Azure:mainfrom
alzimmermsft:AzCore_AddHttpHeaderNameApisToHttpLogOptions

Conversation

@alzimmermsft
Copy link
Copy Markdown
Member

@alzimmermsft alzimmermsft commented Sep 30, 2024

Description

Resolves #42073

Adds APIs to HttpLogOptions to use HttpHeaderName instead of String when dealing with headers that can be logged. Additionally, deprecates prettyPrint and the String-based headers APIs in HttpLogOptions.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Sep 30, 2024
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Sep 30, 2024 •
edited
Loading

API change check

API changes are not detected in this pull request.

@alzimmermsft alzimmermsft merged commit 25c62f5 into Azure:main Oct 17, 2024
@alzimmermsft alzimmermsft deleted the AzCore_AddHttpHeaderNameApisToHttpLogOptions branch October 17, 2024 17:33
rajeshka pushed a commit that referenced this pull request May 13, 2026
Add VMSS Lifecycle Hook events (PR #40499) to system events
9208b97 
Regenerated from azure-rest-api-specs commit 7089f3d2a4ed7e765d66f5f5e3be0b8b1eed6c1a
which includes:
- PR #42138: Adding new properties for ACSMessaging and IncomingCall events
- PR #39046: Update Chat event to include sequenceId
- PR #40499: Add VMSS Lifecycle Hook events to EG ST
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@billwert billwert Awaiting requested review from billwert

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@mssfang mssfang Awaiting requested review from mssfang

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@christothes christothes Awaiting requested review from christothes christothes is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@rujche rujche Awaiting requested review from rujche rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

1 more reviewer

@lmolkova lmolkova lmolkova approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alzimmermsft alzimmermsft

Labels

Azure.Core azure-core Azure.Identity

Projects

Azure Identity SDK Improvements
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add overloads in HttpLogOptions that use HttpHeaderName when it comes to header logging.

3 participants

@alzimmermsft @azure-sdk @lmolkova