Skip to content

Add support for static headers and query params in compile time codegen#44750

Merged
samvaity merged 9 commits intoAzure:mainfrom
samvaity:static-headers
Apr 17, 2025
Merged

Add support for static headers and query params in compile time codegen#44750
samvaity merged 9 commits intoAzure:mainfrom
samvaity:static-headers

Conversation

@samvaity
Copy link
Member

@samvaity samvaity commented Mar 21, 2025 •
edited
Loading

Description

Closes: #44747

  • Updates the usage of static query params to use the same pattern as static headers for consistency
  • static headers cannot be overridden by dynamic, even if provided so in the service interface

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 21, 2025 •
edited
Loading

API change check

API changes are not detected in this pull request.

@samvaity samvaity force-pushed the static-headers branch 2 times, most recently from f7dbc6f to d19344e Compare March 21, 2025 06:21
@samvaity samvaity marked this pull request as ready for review March 21, 2025 16:11
@samvaity
Copy link
Member Author

samvaity commented Mar 21, 2025

@JonathanGiles / @srnagar / @alzimmermsft Based on our offline conversation, it appears that the static headers concept is not widely used, and it is primarily utilized by management libraries. The PR is currently on hold, pending that discussion.

@samvaity samvaity self-assigned this Mar 21, 2025
@samvaity samvaity added the Azure.Core.V2 Contains issues to consider when desiging Azure Core V2 label Mar 25, 2025
@samvaity samvaity added this to the 2025-04 milestone Mar 25, 2025
@samvaity samvaity force-pushed the static-headers branch 2 times, most recently from 50d417f to 71413ae Compare April 10, 2025 19:48
@samvaity samvaity changed the title Add support for static headers in compile time codegen Add support for static headers and query params in compile time codegen Apr 10, 2025
@samvaity samvaity force-pushed the static-headers branch 2 times, most recently from c93b210 to 16857ab Compare April 11, 2025 19:06
alzimmermsft
alzimmermsft reviewed Apr 14, 2025
View reviewed changes
@samvaity samvaity merged commit 520d21e into Azure:main Apr 17, 2025
58 checks passed
@samvaity samvaity mentioned this pull request Apr 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

Assignees

@samvaity samvaity

Labels

Azure.Core.V2 Contains issues to consider when desiging Azure Core V2 clientcore

Projects

None yet

Milestone

2025-04

Development

Successfully merging this pull request may close these issues.

Add support for static headers on HttpRequestInformation in compile time codegen

4 participants

@samvaity @azure-sdk @alzimmermsft @srnagar