Change default value for Cosmos BulkWriter progress interval check#44773
Closed
c21 wants to merge 2 commits intoAzure:mainfrom
Closed
Change default value for Cosmos BulkWriter progress interval check#44773c21 wants to merge 2 commits intoAzure:mainfrom
c21 wants to merge 2 commits intoAzure:mainfrom
Conversation
Contributor
|
Thank you for your contribution @c21! We will review the pull request and get back to you soon. |
Author
|
@microsoft-github-policy-service agree |
Member
|
This change has been merged in PR #44992 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default value for
maxNoProgressIntervalInSecondsandmaxRetryNoProgressIntervalInSecondslooks to be wrong, compared to https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/CosmosConfig.scala#L1181-L1182 .The issue we are seeing is during FlushAndClose, BulkWriter has thrown exceptions in Spark tasks.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines