Fix parent POM dependency resolution in From Source generator#48482
Merged
weidongxu-microsoft merged 1 commit intoAzure:mainfrom Mar 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the From Source aggregate POM generator to correctly resolve dependencies declared in multi-level parent POM hierarchies (e.g., Cosmos Spark), by recursing up the parent chain instead of only considering the immediate parent’s dependencies.
Changes:
- Update
resolve_project_dependenciesto add the parent POM itself and recursively resolve its dependencies and ancestors. - Prevent duplicate parent processing by short-circuiting when a parent POM has already been added to the dependency set.
weidongxu-microsoft
approved these changes
Mar 19, 2026
weidongxu-microsoft
approved these changes
Mar 19, 2026
raych1
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes handling of parent POM dependencies in
generate_from_source_pom.pywhere resolving dependencies for parent POMs only checked that parent of the current POM. This handling worked in most cases as almost all libraries in the repository use a direct parent ofazure-client-sdk-parent, and its parent POM doesn't have any dependencies. This breaks down in cases of Cosmos's Spark libraries where there are multiple layers of parent POMs with the base parent containing dependencies.The change in this PR is when handling parent POMs, deeply check them by recursing and go up the parent tree until we hit the root parent (or hit a parent that has already been added as a dependency).
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines