Sync .github directory with azure-sdk-tools for PR 15134#48819
Open
Sync .github directory with azure-sdk-tools for PR 15134#48819
Conversation
Agent-Logs-Url: https://github.com/Azure/azure-sdk-tools/sessions/0a4d8e3c-c96b-4265-905c-5f8918876354 Co-authored-by: raych1 <20296335+raych1@users.noreply.github.com>
…eSpace guard Agent-Logs-Url: https://github.com/Azure/azure-sdk-tools/sessions/61d68e76-9b14-444b-b244-44d770e9a9b2 Co-authored-by: raych1 <20296335+raych1@users.noreply.github.com>
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
Synchronizes the post-apiview GitHub Actions workflow with changes from azure-sdk-tools PR 15134, intending to pass the GitHub Actions run URL into the APIView PR comment logic.
Changes:
- Pass a new
-GitHubActionRunUrlargument toSet-ApiViewCommentForRelatedIssues. - Add
GITHUB_ACTION_RUN_URLenvironment variable construction for the workflow run URL.
Comment on lines
+34
to
+37
| Set-ApiViewCommentForRelatedIssues -HeadCommitish ${{ github.event.check_run.head_sha }} -AuthToken ${{ secrets.GITHUB_TOKEN }} -GitHubActionRunUrl $env:GITHUB_ACTION_RUN_URL | ||
| shell: pwsh | ||
| env: | ||
| GITHUB_ACTION_RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} |
There was a problem hiding this comment.
Set-ApiViewCommentForRelatedIssues in eng/common/scripts/Helpers/ApiView-Helpers.ps1 only declares parameters HeadCommitish, APIViewHost, and AuthToken (no GitHubActionRunUrl). Passing -GitHubActionRunUrl here will cause the workflow step to fail with an unknown parameter error. Either remove this argument/env var from the workflow, or update ApiView-Helpers.ps1 in this repo to accept/use GitHubActionRunUrl (matching the synced azure-sdk-tools change).
Suggested change
| Set-ApiViewCommentForRelatedIssues -HeadCommitish ${{ github.event.check_run.head_sha }} -AuthToken ${{ secrets.GITHUB_TOKEN }} -GitHubActionRunUrl $env:GITHUB_ACTION_RUN_URL | |
| shell: pwsh | |
| env: | |
| GITHUB_ACTION_RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} | |
| Set-ApiViewCommentForRelatedIssues -HeadCommitish ${{ github.event.check_run.head_sha }} -AuthToken ${{ secrets.GITHUB_TOKEN }} | |
| shell: pwsh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync .github directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15134 See eng/common workflow