Skip to content

[AutoPR azure-resourcemanager-storage]-generated-from-SDK Generation - Java-6263783#49088

Merged
blueww merged 4 commits into
mainfrom
sdkauto/azure-resourcemanager-storage-6263783
May 20, 2026
Merged

[AutoPR azure-resourcemanager-storage]-generated-from-SDK Generation - Java-6263783#49088
blueww merged 4 commits into
mainfrom
sdkauto/azure-resourcemanager-storage-6263783

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

@azure-sdk azure-sdk commented May 7, 2026

Configurations: 'specification/storage/Storage.Management/tspconfig.yaml', API Version: 2025-08-01, SDK Release Type: stable, and CommitSHA: 'c163f6899d149b267dd3e865d3fd09fa23bb6255' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6263783 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://apps.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=3044af4d-f349-f111-bec7-000d3a5c46b0 Submitted by: weiwei@microsoft.com

Release Plan Details

@blueww
Copy link
Copy Markdown
Member

blueww commented May 14, 2026

@weidongxu-microsoft

I see the changelog include a lot of breaking change, not only the APIs changed in this API version, but also APIs not changed in this API version. Are they expected?
Does the breaking caused by TSP migration? Should we try to avoid breaking as much as possible?

@weidongxu-microsoft
Copy link
Copy Markdown
Member

weidongxu-microsoft commented May 15, 2026

@weidongxu-microsoft

I see the changelog include a lot of breaking change, not only the APIs changed in this API version, but also APIs not changed in this API version. Are they expected? Does the breaking caused by TSP migration? Should we try to avoid breaking as much as possible?

We've reviewed the breaking changes during TypeSpec migration. They will not impact customer.

There are basically 2 categories

  1. Moving ResultList/Collection model to implementation package. E.g. ListQueueResource. They are Response model of the API, which customer will not see and use. Customer will see PagedIterable<ListQueueInner> as response of SDK API.
  2. Remove of ctor and setter on Read-only model. E.g. LegalHoldProperties. The model is read-only in ContainerProperties and BlobContainerInner. Customer has no reason to create the model or set its property.

We will clean up the CHANGELOG after PR be ready-to-review.

@blueww blueww marked this pull request as ready for review May 19, 2026 08:29
Copilot AI review requested due to automatic review settings May 19, 2026 08:29
@blueww
Copy link
Copy Markdown
Member

blueww commented May 19, 2026

Hi @weidongxu-microsoft
This PR is ready to review.
We plan to release the SDK before 5/22. Would you please help to make the PR ready for merge before 5/21?
Thanks!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Auto-generated SDK update for azure-resourcemanager-storage from TypeSpec spec commit b373ded4..., targeting Storage Management API version 2025-08-01 and promoting the package from 2.56.0-beta.1 to the stable 2.56.0 release.

Changes:

  • Introduces dedicated *Update model types (e.g., ConnectorUpdate, DataShareUpdate, StorageDataSharePropertiesUpdate, StorageConnectorPropertiesUpdate, TrackedResourceUpdate, etc.) and switches ConnectorsClient.update / DataSharesClient.update to use them instead of the *Inner create models.
  • Updates sample code to use the new update models, renames withStartFromwithStartOn in the storage task assignment sample, and uses the typed StorageDataShareAccessPolicyPermission.READ constant.
  • Updates MinimumTlsVersion documentation to call out that TLS 1.3 is not supported, bumps version to 2.56.0, refreshes CHANGELOG, metadata, and tsp-location.yaml.

Reviewed changes

Copilot reviewed 30 out of 34 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/storage/azure-resourcemanager-storage/tsp-location.yaml Pin to new spec commit.
sdk/storage/azure-resourcemanager-storage/pom.xml Bump version to 2.56.0.
sdk/storage/azure-resourcemanager-storage/README.md Update version reference.
sdk/storage/azure-resourcemanager-storage/CHANGELOG.md Document breaking changes and new features for 2.56.0.
eng/versioning/version_client.txt Update tracked version to 2.56.0.
.../fluent/ConnectorsClient.java, .../DataSharesClient.java Switch update method signatures to new *Update types.
.../implementation/ConnectorsClientImpl.java, .../DataSharesClientImpl.java Implementation updates for new update payload types.
.../fluent/models/ConnectorInner.java, .../DataShareInner.java Re-add required properties validation with ClientLogger.
.../fluent/models/StorageTaskAssignmentInner.java Add systemData, drop required properties validation.
.../fluent/models/StorageAccount*Parameters.java, StorageAccountInner.java Update minimumTlsVersion doc strings.
.../models/MinimumTlsVersion.java, StorageAccountCreateParameters.java, StorageAccountUpdateParameters.java Doc updates for TLS 1.3 note.
.../models/ConnectorUpdate.java, DataShareUpdate.java, TrackedResourceUpdate.java, StorageConnector*Update.java, StorageDataSharePropertiesUpdate.java, DataShareSourceUpdate.java, ManagedIdentityAuthPropertiesUpdate.java New update model classes.
.../models/StorageDataShareProperties.java Expanded Javadoc for Create/Update semantics.
src/main/resources/META-INF/azure-resourcemanager-storage_metadata.json Regenerated metadata listing new generated files.
samples/.../ConnectorsUpdateSamples.java, DataSharesUpdateSamples.java, DataSharesCreateSamples.java, StorageTaskAssignmentsCreateSamples.java Sample code updated to new APIs (*Update models, withStartOn, READ enum).

Copy link
Copy Markdown
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weidongxu-microsoft
Copy link
Copy Markdown
Member

weidongxu-microsoft commented May 20, 2026

@blueww ready to merge

@blueww
Copy link
Copy Markdown
Member

blueww commented May 20, 2026

Is there still any SDK release blocker?
We need release the SDK before 5/22, so the PR need be ready for merge before 5/21.

@blueww
Copy link
Copy Markdown
Member

blueww commented May 20, 2026

@XiaofeiCao , @weidongxu-microsoft
Just to confirm, may I merge this PR now?

@weidongxu-microsoft
Copy link
Copy Markdown
Member

@blueww

I don't see any blocker. You can merge any time you want.

@blueww blueww merged commit 2d8846f into main May 20, 2026
17 checks passed
@blueww blueww deleted the sdkauto/azure-resourcemanager-storage-6263783 branch May 20, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants