[AutoPR azure-resourcemanager-storage]-generated-from-SDK Generation - Java-6263783#49088
Conversation
…aml', API Version: 2025-08-01, SDK Release Type: stable, and CommitSHA: 'c163f6899d149b267dd3e865d3fd09fa23bb6255' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6263783 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
I see the changelog include a lot of breaking change, not only the APIs changed in this API version, but also APIs not changed in this API version. Are they expected? |
We've reviewed the breaking changes during TypeSpec migration. They will not impact customer. There are basically 2 categories
We will clean up the CHANGELOG after PR be ready-to-review. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…aml', and CommitSHA: 'b373ded4a6c77a9f541ca8f020fd2072db632751' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6318918 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Hi @weidongxu-microsoft |
There was a problem hiding this comment.
Pull request overview
Auto-generated SDK update for azure-resourcemanager-storage from TypeSpec spec commit b373ded4..., targeting Storage Management API version 2025-08-01 and promoting the package from 2.56.0-beta.1 to the stable 2.56.0 release.
Changes:
- Introduces dedicated
*Updatemodel types (e.g.,ConnectorUpdate,DataShareUpdate,StorageDataSharePropertiesUpdate,StorageConnectorPropertiesUpdate,TrackedResourceUpdate, etc.) and switchesConnectorsClient.update/DataSharesClient.updateto use them instead of the*Innercreate models. - Updates sample code to use the new update models, renames
withStartFrom→withStartOnin the storage task assignment sample, and uses the typedStorageDataShareAccessPolicyPermission.READconstant. - Updates
MinimumTlsVersiondocumentation to call out that TLS 1.3 is not supported, bumps version to2.56.0, refreshes CHANGELOG, metadata, andtsp-location.yaml.
Reviewed changes
Copilot reviewed 30 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure-resourcemanager-storage/tsp-location.yaml | Pin to new spec commit. |
| sdk/storage/azure-resourcemanager-storage/pom.xml | Bump version to 2.56.0. |
| sdk/storage/azure-resourcemanager-storage/README.md | Update version reference. |
| sdk/storage/azure-resourcemanager-storage/CHANGELOG.md | Document breaking changes and new features for 2.56.0. |
| eng/versioning/version_client.txt | Update tracked version to 2.56.0. |
| .../fluent/ConnectorsClient.java, .../DataSharesClient.java | Switch update method signatures to new *Update types. |
| .../implementation/ConnectorsClientImpl.java, .../DataSharesClientImpl.java | Implementation updates for new update payload types. |
| .../fluent/models/ConnectorInner.java, .../DataShareInner.java | Re-add required properties validation with ClientLogger. |
| .../fluent/models/StorageTaskAssignmentInner.java | Add systemData, drop required properties validation. |
| .../fluent/models/StorageAccount*Parameters.java, StorageAccountInner.java | Update minimumTlsVersion doc strings. |
| .../models/MinimumTlsVersion.java, StorageAccountCreateParameters.java, StorageAccountUpdateParameters.java | Doc updates for TLS 1.3 note. |
| .../models/ConnectorUpdate.java, DataShareUpdate.java, TrackedResourceUpdate.java, StorageConnector*Update.java, StorageDataSharePropertiesUpdate.java, DataShareSourceUpdate.java, ManagedIdentityAuthPropertiesUpdate.java | New update model classes. |
| .../models/StorageDataShareProperties.java | Expanded Javadoc for Create/Update semantics. |
| src/main/resources/META-INF/azure-resourcemanager-storage_metadata.json | Regenerated metadata listing new generated files. |
| samples/.../ConnectorsUpdateSamples.java, DataSharesUpdateSamples.java, DataSharesCreateSamples.java, StorageTaskAssignmentsCreateSamples.java | Sample code updated to new APIs (*Update models, withStartOn, READ enum). |
There was a problem hiding this comment.
@XiaofeiCao for review
I've asked agent to double checked the CHANGELOG, that they are expected as #49088 (comment).
|
@blueww ready to merge |
|
Is there still any SDK release blocker? |
|
@XiaofeiCao , @weidongxu-microsoft |
|
I don't see any blocker. You can merge any time you want. |
Configurations: 'specification/storage/Storage.Management/tspconfig.yaml', API Version: 2025-08-01, SDK Release Type: stable, and CommitSHA: 'c163f6899d149b267dd3e865d3fd09fa23bb6255' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6263783 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://apps.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=3044af4d-f349-f111-bec7-000d3a5c46b0 Submitted by: weiwei@microsoft.com
Release Plan Details
Spec pull request: [Storage RP] remove specific API version for c# sdk azure-rest-api-specs#42973
Spec API version: