The "flie" configuration in package.json of some RLC packages is missing the apiView and changelog configs

[kazrael2119]

Some RLC packages missed these two configs

    "review/",
    "CHANGELOG.md"

in files:[] under pacakge.json after ESM migration.

and this fails JS automation if we update related configs in spec PR

expected files in package.json:

  "files": [
    "dist/",
    "README.md",
    "LICENSE",
    "review/",
    "CHANGELOG.md"
  ],

current files in package.json:

  "files": [
    "dist/",
    "README.md",
    "LICENSE"
  ],

[kazrael2119]

These rlc packages have this issue:

sdk\agrifood\agrifood-farming-rest\package.json

sdk\ai\ai-inference-rest\package.json

sdk\anomalydetector\ai-anomaly-detector-rest\package.json

sdk\communication\communication-job-router-rest\package.json

sdk\communication\communication-messages-rest\package.json

sdk\confidentialledger\confidential-ledger-rest\package.json

sdk\containerservice\arm-containerservice-rest\package.json

sdk\contentsafety\ai-content-safety-rest\package.json

sdk\devcenter\developer-devcenter-rest\package.json

sdk\deviceupdate\iot-device-update-rest\package.json

sdk\documentintelligence\ai-document-intelligence-rest\package.json

sdk\documenttranslator\ai-document-translator-rest\package.json

sdk\easm\defender-easm-rest\package.json

sdk\face\ai-vision-face-rest\package.json

sdk\healthinsights\health-insights-cancerprofiling-rest\package.json

sdk\healthinsights\health-insights-clinicalmatching-rest\package.json

sdk\healthinsights\health-insights-radiologyinsights-rest\package.json

sdk\loadtesting\load-testing-rest\package.json

sdk\maps\maps-geolocation-rest\package.json

sdk\maps\maps-render-rest\package.json

sdk\maps\maps-route-rest\package.json

sdk\maps\maps-search-rest\package.json

sdk\maps\maps-timezone-rest\package.json

sdk\purview\purview-administration-rest\package.json

sdk\purview\purview-datamap-rest\package.json

sdk\purview\purview-scanning-rest\package.json

sdk\purview\purview-sharing-rest\package.json

sdk\purview\purview-workflow-rest\package.json

sdk\synapse\synapse-access-control-rest\package.json

sdk\translation\ai-translation-document-rest\package.json

sdk\translation\ai-translation-text-rest\package.json

sdk\vision\ai-vision-image-analysis-rest\package.json

and these packages should release a minor version to contain /review and changelog

@azure-rest/agrifood-farming
@azure-rest/ai-inference
@azure-rest/communication-job-router
@azure-rest/communication-messages
@azure-rest/arm-containerservice
@azure-rest/ai-content-safety
@azure-rest/developer-devcenter
@azure-rest/iot-device-update
@azure-rest/ai-document-translator
@azure-rest/ai-vision-face
@azure-rest/defender-easm
@azure-rest/load-testing
@azure-rest/maps-geolocation
@azure-rest/maps-render
@azure-rest/maps-route
@azure-rest/maps-search
@azure-rest/purview-administration
@azure-rest/purview-datamap
@azure-rest/purview-scanning
@azure-rest/purview-sharing
@azure-rest/purview-workflow
@azure-rest/synapse-access-control
@azure-rest/ai-translation-text

[maorleger]

I don't think we should be shipping our review/ md files to customers - those are meant for our usage (reviewing public API changes) and don't need to be shipped. But definitely open to hearing if I missed something!

[qiaozha]

@maorleger this is meaningless to our customers but we have to add it because our changelog tool needs to compare the api diff between latest main and latest npm.

Maybe @wanlwanl could help investigate if we could have a way to auto generate the changelog without including the api view into the package?

[maorleger]

Maybe @wanlwanl could help investigate if we could have a way to auto generate the changelog without including the api view into the package?

Yeah, I'd love that (time permitting of course) 👍

changelog tool needs to compare the api diff between latest main and latest npm.

One thing that comes to mind is git tags (which are auto-generated for every release), for example in keyvault-keys git diff @azure/keyvault-keys_4.9.0 main -- sdk/keyvault/keyvault-keys/review/

Using APIView is another option, there may be others

Thanks for considering it!

[qiaozha]

If we could somehow have the git tag documented, then it sure can fix the changelog generation without pack api view into the package. I have one concern the git tag only gets generated after we release the library, but at that time the library has already been released, right?

[jeremymeng]

I have one concern the git tag only gets generated after we release the library, but at that time the library has already been released, right?

How is the api.md file used in generating changelog?