[Eventhub] TableCheckpointstore base branch #19726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 8, 2021 13:58
Jg1255
requested review from
annatisch,
rakshith91,
swathipil and
yunhaoling
as code owners
ghost
added
Event Hubs
customer-reported
|
Thank you for your contribution Jg1255! We will review the pull request and get back to you soon. |
swathipil
removed
the
customer-reported
added 4 commits
July 8, 2021 14:54
swathipil
reviewed
Jul 9, 2021
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
swathipil
reviewed
Jul 9, 2021
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
chradek
reviewed
Jul 12, 2021
There was a problem hiding this comment.
Looking good, just had a few comments (mostly for @swathipil 😄)
sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/_version.py
Outdated
Show resolved
Hide resolved
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
…b/_version.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
added 2 commits
July 14, 2021 23:32
chradek
reviewed
Jul 15, 2021
sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/_version.py
Outdated
Show resolved
Hide resolved
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
swathipil
reviewed
Jul 16, 2021
swathipil
reviewed
Jul 16, 2021
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
swathipil
reviewed
Jul 16, 2021
sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/template_code.py
Outdated
Show resolved
Hide resolved
swathipil
reviewed
Jul 16, 2021
sdk/eventhub/azure-eventhub-checkpointstoretable/samples/sample_simple.py
Outdated
Show resolved
Hide resolved
swathipil
reviewed
Jul 16, 2021
sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_simple.py
Outdated
Show resolved
Hide resolved
Co-authored-by: chradek <51000525+chradek@users.noreply.github.com>
Co-authored-by: chradek <51000525+chradek@users.noreply.github.com>
Co-authored-by: chradek <51000525+chradek@users.noreply.github.com>
added 2 commits
July 19, 2021 12:50
chradek
reviewed
Jul 19, 2021
There was a problem hiding this comment.
One documentation update otherwise this is looking good to me! It looks like CI is failing at the run tests step, and I am assuming that's because there aren't any tests.
@swathipil in JavaScript we'd just have a single test that made sure we were exporting the TableCheckpointStore at this point. Would you do something similar in python, or is there a way to disable the run tests step until tests are added?
added 2 commits
July 19, 2021 14:20
chradek
approved these changes
Jul 20, 2021
swathipil
reviewed
Jul 21, 2021
sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py
Show resolved
Hide resolved
Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
…orage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
swathipil
approved these changes
Jul 21, 2021
|
Hello @chradek! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding checkingpointstore for table. This is my initial pull request.