[translation] filters renames/alignment #19826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaban-msft
approved these changes
Jul 15, 2021
maririos
approved these changes
Jul 19, 2021
| def convert_order_by(order_by): | ||
| # type: (Optional[List[str]]) -> Optional[List[str]] | ||
| if order_by: | ||
| order_by = [order.replace("created_on", "createdDateTimeUtc") for order in order_by] |
There was a problem hiding this comment.
would this work if the user passes any comb of upper case and lower case for created_on like i.e. Created_on?
not sure if this is a scenario, but asking in case it is important in Python
There was a problem hiding this comment.
Hmm this wouldn't be proper snake case so I wouldn't consider it a scenario. I think I'll let the service validate here, they do send back an error if the query param is not supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19802
translated_beforeandtranslated_afterkwargs tocreated_beforeandcreated_after, respectively,for
list_all_document_statuses. Reasoning is that documents which failed to translate will show up in the query and saying "translated_xx" is not totally correct in this case. Also aligns with .NET naming.order_bysorting query optioncreatedDateTimeUtctocreated_onforlist_all_translation_statusesandlist_all_document_statuses. So people can map this sorting query option to the property on the result model.