[core] loosen check on stream input #23578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
requested review from
annatisch,
johanste,
kashifkhan,
lmazuel,
tjprescott and
xiangyan99
as code owners
ghost
added
the
lmazuel
approved these changes
Mar 18, 2022
xiangyan99
approved these changes
Mar 18, 2022
Member
xiangyan99
left a comment
xiangyan99
left a comment
There was a problem hiding this comment.
Do we still need both rest and rest_py3?
Contributor
Author
|
@xiangyan99 no, I want to refactor that later in a separate PR |
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 7, 2022
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we're more stringent about
contentinput, we expect it to be str / bytes or an iterable / asynciterable. This impacts storage live tests and is also incorrect because we should allow inputs with just aread()proeprty. I'm switching my code to be more like the pipeline transport code here and duck-typing instead.Also at the same time, saw a gap to get rid of some
py2/py3code, so did some code unification as wellRunning against live storage: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1443919&view=results. Will not see all tests passing, @jalauzon-msft is fixing the other failed tests in main right now, but should see the failing stream tests pass