[bct] Checker refactoring + new overload checker #37284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalinaperalta
commented
Sep 12, 2024
kristapratico
approved these changes
Sep 19, 2024
| # -------------------------------------------------------------------------------------------- | ||
| import sys | ||
| import os | ||
| sys.path.append(os.path.abspath("../../scripts/breaking_changes_checker")) |
Member
Author
There was a problem hiding this comment.
I wasnt able to reference the _models from here for some reason :/ I'll look back into why this was necessary in the future (tracking issue: #37914)
scripts/breaking_changes_checker/checkers/added_method_overloads_checker.py
Outdated
Show resolved
Hide resolved
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* fix type parsing * add new overload checker * rename checkers * add base checker prop * comments * refactor pluggable checks * update protocol model * add test * tweak checker calls * update test * loop on valid entries * update checker * fix checkers * mark checkertype as enum * shared method --------- Co-authored-by: Catalina Peralta <caperal@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting the pluggable checker functionality to make it easier to migrate more checks. The design is still in flux but this will facilitate migration so that we can see how we need to refine/optimize the checker design.
Fixes #36986
Tracking issue for future overload work for a different PR: #37033