Support pure pyproject-toml packages
#37882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally parse the metadata proberly now
scbedd
requested review from
benbp,
lmazuel,
mccoyp and
weshaggard
as code owners
Member
Author
|
@mccoyp this is ready to rock and roll. |
scbedd
requested review from
achauhan-scc,
kingernupur and
paulshealy1
as code owners
Collaborator
|
API change check API changes are not detected in this pull request. |
mccoyp
reviewed
Oct 19, 2024
tools/azure-sdk-tools/tests/integration/scenarios/pyproject_build_config/README.md
Outdated
Show resolved
Hide resolved
...re-sdk-tools/tests/integration/scenarios/pyproject_project_def_with_extension/pyproject.toml
Outdated
Show resolved
Hide resolved
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Member
Author
|
@mccoyp addressed your feedback + updated a couple comments. Thanks much for the review! 🎉 |
mccoyp
approved these changes
Oct 21, 2024
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* add support for parsing and building pure pyproject.toml packages within azure-sdk-tools * various typing updates across azure-sdk-tools, cleaning up what code paths I'm touching with the new build and parse support * add tests for various pyproject.toml parse scenarios * bump setuptools to 74.1.3 to support pure-pyproject.toml extension packages (eg without a setup.py) --------- Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title 👍 .
Of course, this is purely "support" and we'll probably find some warts when we migrate the first packages. This has been a long asked-for feature that I've just not had a day to dedicate to. Had a good confluence of availability and lack of interruptions this past Friday.
Working through test failures. With the advent of
setuptools>=74.1extension packages are now supported directly fromsetuptoolsTodo:
setuptools.metaone last time, I have a feeling that patches have resolved the issues I was seeing this past jan74.1.3to prepare for pure pyproject.toml extension packages