Juntuchen/update black #38542
Merged
Juntuchen/update black #38542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juntuchen-msft
requested review from
AikoBB,
maximrytych-ms,
minwoolee-msft and
mjafferi-msft
as code owners
Collaborator
|
API change check API changes are not detected in this pull request. |
juntuchen-msft
requested review from
ChenxiJiang333,
LuChen-Microsoft,
besh2014,
danielav7,
dinazavyr,
gfeitosa-msft,
ilyapaliakou-msft,
miguhern,
msyyc,
phermanov-msft,
sarkar-rajarshi,
whisper6284 and
yogeshmo
as code owners
AikoBB
reviewed
Nov 18, 2024
sdk/communication/azure-communication-identity/azure/communication/identity/_shared/models.py
Show resolved
Hide resolved
Member
|
/azp run python - azure-communication-identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AikoBB
approved these changes
Nov 18, 2024
Member
AikoBB
left a comment
AikoBB
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing black issues in all ACS SDKs! Reviewed identity sdk, lgtm!
mjafferi-msft
approved these changes
Nov 18, 2024
minwoolee-msft
approved these changes
Nov 20, 2024
ilyapaliakou-msft
approved these changes
Nov 20, 2024
whisper6284
approved these changes
Nov 20, 2024
ChenxiJiang333
approved these changes
Nov 21, 2024
maximrytych-ms
approved these changes
Nov 21, 2024
dinazavyr
approved these changes
Nov 21, 2024
LuChen-Microsoft
approved these changes
Nov 21, 2024
gfeitosa-msft
approved these changes
Nov 22, 2024
kristapratico
approved these changes
Nov 22, 2024
msyyc
approved these changes
Nov 25, 2024
Member
msyyc
left a comment
msyyc
left a comment
There was a problem hiding this comment.
Approved for file changes under "azure-mgmt-communication".
yogeshmo
approved these changes
Nov 26, 2024
sarkar-rajarshi
approved these changes
Nov 26, 2024
Member
sarkar-rajarshi
left a comment
sarkar-rajarshi
left a comment
There was a problem hiding this comment.
All good for JobRouter.
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* updated OPSoutgoingCall and Callinvite * updated according to pipeline build * revert change in ci.yml * Fixed pylint issue * updated to fix black * Ran black in all comm services * Ran black for all comm services * updated chat to meet pipeline check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines