new tests #38571
Merged
new tests #38571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Evaluation
Collaborator
|
API change check API changes are not detected in this pull request. |
ninghu
approved these changes
Nov 22, 2024
kdestin
approved these changes
Nov 25, 2024
w-javed
reviewed
Dec 2, 2024
| def test_evaluate_multimodal(self, multi_modal_input_type, multimodal_input_selector, azure_cred, project_scope): | ||
| # Content safety is removed due to being unstable in playback mode | ||
| evaluators = { | ||
| # "content_safety" : ContentSafetyMultimodalEvaluator(credential=azure_cred, azure_ai_project=project_scope), |
Contributor
There was a problem hiding this comment.
What happens when you enable it. Does it fail the test or skip it?
do you have any theory or know root cause, why It must be happening?
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* new tests * remove gleu * run black * skip * test ci: restore multimodal test * test ci: restore conversation test * change skip type * remove skips because they don't work * test only convo in CI * only skip convo test * just run multi * 2 tests * fix param placement * skip multi * just singlton * remove cs from first test * remove rai evals * remove prompty evals * all but 1 eval * update recordings * 2 evals * just cs * 2 rai service * prompty only * disable pf proxy * delay * more fixture tweaks * more os setting * skip windows in CI * re-enabled all tests * remove env setting * re-reacord * disable 1 test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR to add 3 (5 with parameterization) tests to account for ALL e2e runs of evaluators. Current disables 3 evaluators due to consistent problems with playback tests.
Next steps will be to disable tests made redundant by these, and to re-enabled the 3 currently un-touched evaluators.
Also contains an unrelated nit docstring fix.