Skip to content

Add MaaP Finetuning Job implementation. #38650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Dec 3, 2024
Merged

Add MaaP Finetuning Job implementation. #38650

merged 35 commits into from
Dec 3, 2024

Conversation

@sagarsumant
Copy link
Member

@sagarsumant sagarsumant commented Nov 22, 2024 •
edited
Loading

Description

  1. Add implementation for MaaP (Model as a Platform) finetuning job.
  2. I am updating list api version to v2024-10-01-preview in job operations.
  3. For create/update and get have created separate if to use v2024-10-01-preview version.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning labels Nov 22, 2024
@github-actions
Copy link

github-actions bot commented Nov 22, 2024

Thank you for your contribution @sagarsumant! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 22, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@kristapratico kristapratico removed customer-reported Issues that are reported by GitHub users external to the Azure organization. Community Contribution Community members are working on the issue labels Nov 22, 2024
@sagarsumant sagarsumant mentioned this pull request Nov 26, 2024
Merged
6 tasks
achauhan-scc
achauhan-scc reviewed Nov 29, 2024
View reviewed changes
@sagarsumant sagarsumant enabled auto-merge (squash) December 3, 2024 05:58
@sagarsumant sagarsumant disabled auto-merge December 3, 2024 06:04
@sagarsumant sagarsumant enabled auto-merge (squash) December 3, 2024 06:06
@sagarsumant sagarsumant merged commit e6dabc5 into Azure:main Dec 3, 2024
21 checks passed
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
@sagarsumant @l0lawrence
Add MaaP Finetuning Job implementation. (Azure#38650)
23ad5ce 
* WIP

* Fix circular import

* Add queue_settings and resources fields.

* Work in progress.

* Test run successful

* All 3 flavors working in integration tests.

* add unit tests for yaml.

* Add tests for yaml job creation.

* Fix tests.

* Fix test.

* Refactor and update tests.

* Fix things.

* Fix tests.

* Fix failing test.

* Fix tests.

* add @pytest.mark.e2etest

* try recorded test.

* comment status for non live testing.

* Fix things.

* Rebase and fix merge issues.

* format using black.

* format using black.

* Disable recorded test execution

* Remove assets.json changes.

* Fix linting errors.

* Fix imports

* Fix comments.

* Remove job.py changes.

* Fix tests.

---------

Co-authored-by: Sagar Sumant <sasum@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achauhan-scc achauhan-scc achauhan-scc approved these changes

@TonyJ1 TonyJ1 Awaiting requested review from TonyJ1

@wangchao1230 wangchao1230 Awaiting requested review from wangchao1230

@kingernupur kingernupur Awaiting requested review from kingernupur kingernupur is a code owner

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@jayesh-tanna jayesh-tanna Awaiting requested review from jayesh-tanna jayesh-tanna is a code owner

Assignees

No one assigned

Labels

Machine Learning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sagarsumant @azure-sdk @achauhan-scc @kristapratico