-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Use b"" instead of bytes(). Don't use str on a string. #38733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed using ruff check --exclude="script*" --exclude="tools*" --select "UP018" --fix
|
Thank you for your contribution @atombrella! We will review the pull request and get back to you soon. |
|
API change check API changes are not detected in this pull request. |
|
Hi @atombrella thank you for the pr! For SB/EH this looks good to me The CI failures seem to be pre-existing failures in the confidential-ledger pipeline. |
|
@l0lawrence @kashifkhan Just to remind you, I do not have merge rights |
vincenttran-msft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for Storage side in regards to bytes() -> b"", thanks for this!
kristapratico
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @atombrella! This looks good to me
|
/check-enforcer override Pylint failure in confidential ledger is unrelated |
Fixed using ruff check --exclude="script*" --exclude="tools*" --select "UP018" --fix Co-authored-by: Mads Jensen <atombrella@users.noreply.github.com>
Description
https://docs.astral.sh/ruff/rules/native-literals/
Fixed using
Performance improvements:
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines