Skip to content

fix reading blob chars in text mode using StorageStreamDownloader.read() #38827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 6, 2025
Merged

fix reading blob chars in text mode using StorageStreamDownloader.read() #38827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7e69ab3
fix problem with reading blob chars in text mode
mlschodkowski Dec 11, 2024
1b60d74
Update _download.py
mlschodkowski Dec 11, 2024
2f249c9
Update _download.py
mlschodkowski Dec 11, 2024
49b67cc
Update _download.py
mlschodkowski Dec 11, 2024
4a40972
Update _download.py
mlschodkowski Dec 11, 2024
68bf5ec
Fix chars param in download_async.py
mlschodkowski Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-blob/azure/storage/blob/_download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ def read(self, size: int = -1, *, chars: Optional[int] = None) -> T:
output_stream: Union[BytesIO, StringIO]
if self._text_mode:
output_stream = StringIO()
size = chars if chars else sys.maxsize
size = sys.maxsize if chars is None or chars <= 0 else chars
else:
output_stream = BytesIO()
size = size if size > 0 else sys.maxsize
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-blob/azure/storage/blob/aio/_download_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ async def read(self, size: int = -1, *, chars: Optional[int] = None) -> T:
output_stream: Union[BytesIO, StringIO]
if self._text_mode:
output_stream = StringIO()
size = chars if chars else sys.maxsize
size = sys.maxsize if chars is None or chars <= 0 else chars
else:
output_stream = BytesIO()
size = size if size > 0 else sys.maxsize
Expand Down
Loading