remove mgmt from typing exclusion filter #38963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test Azure SDK Tools / build-and-test (pull_request) is failing due to a flaky test that is fixed in this PR: #39027 |
kristapratico
requested review from
benbp,
mccoyp,
scbedd and
weshaggard
as code owners
mccoyp
approved these changes
Jan 7, 2025
Member
mccoyp
left a comment
mccoyp
left a comment
There was a problem hiding this comment.
Minor question, but otherwise LGTM 🙂
singankit
pushed a commit
that referenced
this pull request
Jan 14, 2025
* remove mgmt from mypy global exclusion * touch mgmt code to trigger pipeline * Revert "touch mgmt code to trigger pipeline" This reverts commit c95a4a8. * update mypy and pyright to run on generated_samples dir * redefine filter for health status script * test mgmt * Revert "test mgmt" This reverts commit e140847. * mccoy feedback
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* remove mgmt from mypy global exclusion * touch mgmt code to trigger pipeline * Revert "touch mgmt code to trigger pipeline" This reverts commit c95a4a8. * update mypy and pyright to run on generated_samples dir * redefine filter for health status script * test mgmt * Revert "test mgmt" This reverts commit e140847. * mccoy feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38904
We plan to start running typing checks against mgmt so this PR updates mgmt to use pyproject.toml for enabling/disabling typing checks instead of an exclusion filter. This also updates mypy/pyright to check the generated_samples directory for type checking against mgmt samples.
Commit that disabled typing checks for mgmt in each pyproject.toml: 7e5cdb2