[Core] Update DistributedTracingPolicy spans
#39959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed some Microsoft specific span attributes - Updated default HTTP span name to just the HTTP method. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
core-tracing-semconv-updates
branch
from
2b44b8f to
fe968b3
Compare
Contributor
There was a problem hiding this comment.
PR Overview
This PR updates the DistributedTracingPolicy spans following OpenTelemetry conventions by changing the default span name from the URL path to the HTTP method and renaming certain span attribute names.
- Updated the CHANGELOG to document the changes in span naming and attribute renaming.
- Modified tests to assert the updated span names and attribute keys.
- Updated the default network span namer and adjusted attribute extraction in DistributedTracingPolicy.
Reviewed Changes
| File | Description |
|---|---|
| sdk/core/azure-core/CHANGELOG.md | Documented changes to span naming and attribute renaming |
| sdk/core/azure-core-tracing-opentelemetry/tests/test_storage_live.py | Updated expected span name for HTTP spans |
| sdk/core/azure-core/tests/test_tracing_policy.py | Adjusted span name checks from URL path to HTTP method in tests |
| sdk/core/azure-core/azure/core/pipeline/policies/_distributed_tracing.py | Changed default network span namer to use HTTP method and updated attribute mapping |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Collaborator
|
API change check API changes are not detected in this pull request. |
pvaneck
requested review from
annatisch,
iscai-msft,
johanste,
kashifkhan,
lmazuel and
xiangyan99
as code owners
kashifkhan
reviewed
Mar 6, 2025
sdk/core/azure-core/azure/core/pipeline/policies/_distributed_tracing.py
Show resolved
Hide resolved
kashifkhan
approved these changes
Mar 6, 2025
allenkim0129
pushed a commit
to allenkim0129/azure-sdk-for-python
that referenced
this pull request
Mar 11, 2025
- Renamed some Microsoft specific span attributes - Updated default HTTP span name to just the HTTP method. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are technically breaking changes in the sense that some span-related things are renamed, but these shouldn't really break people in practice.