Skip to content

Conversation

@JennyPng
Copy link
Member

@JennyPng JennyPng commented Nov 13, 2025

#42883

tested with

  • azure-mgmt-core
  • azure-mgmt-storage

@JennyPng JennyPng marked this pull request as ready for review November 13, 2025 01:06
Copilot AI review requested due to automatic review settings November 13, 2025 01:06
@JennyPng JennyPng requested a review from benbp as a code owner November 13, 2025 01:06
Copilot finished reviewing on behalf of JennyPng November 13, 2025 01:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for running the breaking changes checker directly via the azpysdk CLI tool without requiring tox. The change simplifies the workflow by providing a more straightforward command (azpysdk breaking .) for local testing.

  • Implements a new breaking command in the azpysdk tool
  • Updates documentation to include the new non-tox workflow
  • Integrates breaking changes detection into the existing CLI infrastructure

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
scripts/breaking_changes_checker/README.md Documents the new azpysdk breaking command usage
eng/tools/azure-sdk-tools/azpysdk/main.py Registers the new breaking check command with the CLI parser
eng/tools/azure-sdk-tools/azpysdk/breaking.py Implements the breaking changes check as a CLI command
doc/tool_usage_guide.md Adds breaking check to the tool usage documentation table

@scbedd
Copy link
Member

scbedd commented Nov 13, 2025

Oh. Apply black! That's what's failing in azure-sdk-tools checks.

@JennyPng JennyPng enabled auto-merge (squash) November 13, 2025 20:25
@JennyPng JennyPng merged commit 37cb1cf into Azure:main Nov 13, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants