Skip to content

Change import path for LoggingHandler to accommodate upstream breaking changes #45516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rads-1996 merged 18 commits into from
Mar 18, 2026
+23 −38
Merged

Change import path for LoggingHandler to accommodate upstream breaking changes #45516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ca55d93
Modify import for LoggingHandler following breaking changes in upstre…
rads-1996 Feb 26, 2026
d9b8aa8
Updated README and setup.py
rads-1996 Mar 4, 2026
4eda687
Update CHANGELOG
rads-1996 Mar 4, 2026
6f4cb1e
Update sdk version
rads-1996 Mar 4, 2026
299af3e
Fix dep issue
rads-1996 Mar 4, 2026
732ea30
Revert doc change to check if CI/CD passes
rads-1996 Mar 5, 2026
06cba31
Fix dep in exporter
rads-1996 Mar 5, 2026
264e28d
Move distro changes out to another PR
rads-1996 Mar 5, 2026
9d602af
Add back comma
rads-1996 Mar 5, 2026
716d2b2
Update CHANGELOG
rads-1996 Mar 5, 2026
a001fd2
fix dep
rads-1996 Mar 5, 2026
d73c432
Retrigger CI/CD pipeline
rads-1996 Mar 6, 2026
5fb7ae9
Retrigger CI/CD pipeline
rads-1996 Mar 6, 2026
3000f72
Update CHANGELOG
rads-1996 Mar 6, 2026
cf836a0
Merge branch 'main' into logging-handler
rads-1996 Mar 6, 2026
7aa0483
Merge branch 'main' into logging-handler
rads-1996 Mar 17, 2026
52ba7c8
Merge branch 'main' into logging-handler
rads-1996 Mar 18, 2026
d8dcc5d
Merge branch 'main' into logging-handler
rads-1996 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
([#45252](https://github.com/Azure/azure-sdk-for-python/pull/45252))

### Other Changes
- Change import path for `LoggingHandler` to accommodate upstream breaking changes -
[core](https://github.com/open-telemetry/opentelemetry-python/pull/4919) and [contrib](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4210)
([#45516](https://github.com/Azure/azure-sdk-for-python/pull/45516))

## 1.0.0b48 (2026-02-05)

Expand Down
24 changes: 8 additions & 16 deletions sdk/monitor/azure-monitor-opentelemetry-exporter/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,8 @@ import os
import logging

from opentelemetry._logs import set_logger_provider
from opentelemetry.sdk._logs import (
LoggerProvider,
LoggingHandler,
)
from opentelemetry.sdk._logs import LoggerProvider
from opentelemetry.instrumentation.logging.handler import LoggingHandler
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor

from azure.monitor.opentelemetry.exporter import AzureMonitorLogExporter
Expand Down Expand Up @@ -214,12 +212,10 @@ import logging

from opentelemetry import trace
from opentelemetry._logs import set_logger_provider
from opentelemetry.sdk._logs import (
LoggerProvider,
LoggingHandler,
)
from opentelemetry.sdk._logs import LoggerProvider
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor
from opentelemetry.sdk.trace import TracerProvider
from opentelemetry.instrumentation.logging.handler import LoggingHandler

from azure.monitor.opentelemetry.exporter import AzureMonitorLogExporter

Expand Down Expand Up @@ -256,10 +252,8 @@ import os
import logging

from opentelemetry._logs import set_logger_provider
from opentelemetry.sdk._logs import (
LoggerProvider,
LoggingHandler,
)
from opentelemetry.sdk._logs import LoggerProvider
from opentelemetry.instrumentation.logging.handler import LoggingHandler
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor

from azure.monitor.opentelemetry.exporter import AzureMonitorLogExporter
Expand Down Expand Up @@ -296,10 +290,8 @@ from opentelemetry._logs import (
get_logger_provider,
set_logger_provider,
)
from opentelemetry.sdk._logs import (
LoggerProvider,
LoggingHandler,
)
from opentelemetry.sdk._logs import LoggerProvider
from opentelemetry.instrumentation.logging.handler import LoggingHandler
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor

from azure.monitor.opentelemetry.exporter import AzureMonitorLogExporter
Expand Down
6 changes: 2 additions & 4 deletions sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_correlate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@
get_logger_provider,
set_logger_provider,
)
from opentelemetry.sdk._logs import (
LoggerProvider,
LoggingHandler,
)
from opentelemetry.sdk._logs import LoggerProvider
from opentelemetry.instrumentation.logging.handler import LoggingHandler
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor
from opentelemetry.sdk.trace import TracerProvider

Expand Down
6 changes: 2 additions & 4 deletions sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_custom_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@
get_logger_provider,
set_logger_provider,
)
from opentelemetry.sdk._logs import (
LoggerProvider,
LoggingHandler,
)
from opentelemetry.sdk._logs import LoggerProvider
from opentelemetry.instrumentation.logging.handler import LoggingHandler
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor

from azure.monitor.opentelemetry.exporter import AzureMonitorLogExporter
Expand Down
6 changes: 2 additions & 4 deletions sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_exception.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,8 @@
get_logger_provider,
set_logger_provider,
)
from opentelemetry.sdk._logs import (
LoggerProvider,
LoggingHandler,
)
from opentelemetry.sdk._logs import LoggerProvider
from opentelemetry.instrumentation.logging.handler import LoggingHandler
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor

from azure.monitor.opentelemetry.exporter import AzureMonitorLogExporter
Expand Down
6 changes: 2 additions & 4 deletions sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@
get_logger_provider,
set_logger_provider,
)
from opentelemetry.sdk._logs import (
LoggerProvider,
LoggingHandler,
)
from opentelemetry.sdk._logs import LoggerProvider
from opentelemetry.instrumentation.logging.handler import LoggingHandler
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor

from azure.monitor.opentelemetry.exporter import AzureMonitorLogExporter
Expand Down
6 changes: 2 additions & 4 deletions sdk/monitor/azure-monitor-opentelemetry-exporter/samples/logs/sample_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,8 @@
get_logger_provider,
set_logger_provider,
)
from opentelemetry.sdk._logs import (
LoggerProvider,
LoggingHandler,
)
from opentelemetry.sdk._logs import LoggerProvider
from opentelemetry.instrumentation.logging.handler import LoggingHandler
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor

from azure.monitor.opentelemetry.exporter import AzureMonitorLogExporter
Expand Down
4 changes: 2 additions & 2 deletions sdk/monitor/azure-monitor-opentelemetry-exporter/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@
"azure-core<2.0.0,>=1.28.0",
"azure-identity~=1.17",
"msrest>=0.6.10",
"opentelemetry-api==1.39",
"opentelemetry-sdk==1.39",
"opentelemetry-api==1.40",
"opentelemetry-sdk==1.40",
Copy link
Member

@xiangyan99 xiangyan99 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with the version in sdk/monitor/azure-monitor-opentelemetry

Copy link
Member Author

@rads-1996 rads-1996 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the versions in azure-monitor-opentelemetry after the exporter is released. azure-monitor-opentelemetry depends on the exporter, so the versions have to updated there first before making changes in azure-monitor-opentelemetry

Copy link
Member

@xiangyan99 xiangyan99 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update it now? It blocks the azure-core release.

Copy link
Member Author

@rads-1996 rads-1996 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update it now? It blocks the azure-core release.

I am trying to release the exporter. Until that is released, the distro changes will fail, even if I update them. Give me some time, I am working on releasing the exporter.

Copy link
Member

@scbedd scbedd Mar 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rads-1996 what is your alias? I'll reach out over teams. You can skip the failing check with a queue time build variable of Skip.AnalyzeDependencies with value of true to get your release out.

Copy link
Member Author

@rads-1996 rads-1996 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a commit I can use to release the exporter? If I use the https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6030525, it fails because of the dependency mismatch, I am using the skip.test=true and BuildTargetingString = azure-monitor-opentelemetry-exporter

Copy link
Member Author

@rads-1996 rads-1996 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiangyan99 I have released the exporter and have another PR up for review which updates the otel versions in azure-monitor-opentelemetry - #45539. Once it is approved, I will merge the PR.

"psutil>=5.9,<8",
],
entry_points={
Expand Down
Loading