Remove unnecessary import of pip in Sphinx conf.py #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "import pip" in doc/conf.py added an unnecessary build dependency. It appeared to be there as at one point a theme for Sphinx was installed from pip, but now the rtd theme is used instead.
|
"As a community member you must sign the Contribution License Agreement (CLA) before you can contribute to Microsoft open source projects." I explicitly do not agree to any CLA, unless you're willing to pay for the lawyers to allow me to understand it. I do not believe that this contribution is protected under copyright law, however, due to it being a trivial change. |
|
Hi @irl , thanks for the PR, LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "import pip" in doc/conf.py added an unnecessary build dependency. It appeared to be there as at one point a theme for Sphinx was installed from pip, but now the rtd theme is used instead.