ACR Admin module - Pester Test fixes #124

larisaborodina · 2021-08-05T17:52:43Z

No description provided.

ACR auto-generating cmdlets.

…a/azurestack-powershell into release/acrchanges

Release/acrchanges

bganapa · 2021-08-09T23:00:05Z

/azp run

azure-pipelines · 2021-08-09T23:00:36Z

Azure Pipelines successfully started running 3 pipeline(s).

TheOnlyWei · 2021-08-10T01:01:22Z

@larisaborodina Running autorest on my local machine with branch "msazurestackworkloads:releases/acrchanges" failed with the below error. Are you working on updating our stackadmin2 azure rest API branch as well? That might have to go in first before autorest can work.
https://github.com/Azure/azure-rest-api-specs/tree/stackadmin2. @bganapa For verification.

We will also need to add Azs.ContainerRegistry.Admin to the pipeline ServiceName variable to run the tests in this branch after this is resolved. Right now there is no easy way to add Azs.ContainerRegistry.Admin ServiceName in our pipeline as that will block other PRs as long as this PR is failing. So manual validation of this branch will have to be done. So far the autorest command fails. @larisaborodina you can ping me to learn how to manually validate your changes. Afterward, we will add your Azs.ContainerRegistry.Admin to our pipelines and future changes to your RP will be run in our pipeline automatically.

Failure:
Error: Could not read 'https://github.com/Azure/azure-rest-api-specs/tree/stackadmin2/specification/azsadmin/resource-manager/conttainerregistry/readme.azsautogen.md'.
Error: Could not read 'https://github.com/Azure/azure-rest-api-specs/tree/stackadmin2/specification/azsadmin/resource-manager/conttainerregistry/readme.azsautogen.md'.
    at ReadThroughDataSource.readStrict (C:\Users\weshi1\AppData\Roaming\npm\node_modules\autorest\dist\app.js:5607:19)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at ConfigurationLoader.resolveRequiredConfigs (C:\Users\weshi1\AppData\Roaming\npm\node_modules\autorest\dist\app.js:4671:30) 
    at ConfigurationLoader.loadConfigFile (C:\Users\weshi1\AppData\Roaming\npm\node_modules\autorest\dist\app.js:4654:9)
    at ConfigurationLoader.load (C:\Users\weshi1\AppData\Roaming\npm\node_modules\autorest\dist\app.js:4589:13)                   
    at Object.findCoreVersionUsingConfiguration (C:\Users\weshi1\AppData\Roaming\npm\node_modules\autorest\dist\app.js:504:24)   
    at Object.resolveCoreVersion (C:\Users\weshi1\AppData\Roaming\npm\node_modules\autorest\dist\app.js:540:28)
    at main (C:\Users\weshi1\AppData\Roaming\npm\node_modules\autorest\dist\app.js:186:33)

Add examples for all the cmdlets.

…1.3 version.

Increase vertion to 0.2.0 to avoid clashing with manually released 0.…

bganapa · 2021-08-18T23:50:39Z

Working with larisa on getting this PR merged

src/Azs.ContainerRegistry.Admin/readme.md

src/readme.azurestack.md

src/Azs.ContainerRegistry.Admin/examples/Read-AzsContainerRegistry.md

Replace Read-AzsContainerRegistry to Get-AzsContainerRegistry.

…a/azurestack-powershell into release/acrchanges

ACR Admin module Initial version

bganapa · 2021-08-23T18:54:40Z

/azp run

azure-pipelines · 2021-08-23T18:54:53Z

Azure Pipelines successfully started running 3 pipeline(s).

bganapa · 2021-08-23T21:36:06Z

closing this as we merged the other PR #130

Fixed tests running locally, updated docs.

bganapa · 2021-08-30T23:39:18Z

/azp run

azure-pipelines · 2021-08-30T23:39:29Z

Azure Pipelines successfully started running 3 pipeline(s).

Pester Test fixes

bganapa · 2021-09-01T01:37:20Z

/azp run

azure-pipelines · 2021-09-01T01:37:31Z

Azure Pipelines successfully started running 3 pipeline(s).

bganapa · 2021-09-01T03:42:43Z

/azp run

azure-pipelines · 2021-09-01T03:42:54Z

Azure Pipelines successfully started running 3 pipeline(s).

bganapa · 2021-09-01T17:33:05Z

/azp run

azure-pipelines · 2021-09-01T17:33:17Z

Azure Pipelines successfully started running 3 pipeline(s).

rjaini and others added 8 commits April 13, 2021 12:47

Initial code changes

e71e750

ACR auto-generating cmdlets.

e953c3d

Merge pull request #1 from larisaborodina/release/acrchanges

d40995a

ACR auto-generating cmdlets.

ACR auto-generating cmdlets. - #2

8bc4b41

Merge pull request #2 from larisaborodina/release/acrchanges

579d76f

ACR auto-generating cmdlets.

Add pester tests for all the cmdlets.

d16c156

Merge branch 'release/acrchanges' of https://github.com/larisaborodin…

d62418c

…a/azurestack-powershell into release/acrchanges

Merge pull request #3 from larisaborodina/release/acrchanges

f4aaa5e

Release/acrchanges

larisaborodina requested a review from a team as a code owner August 5, 2021 17:52

larisaborodina requested review from sarathys and removed request for a team August 5, 2021 17:52

bganapa requested review from TheOnlyWei and bganapa August 5, 2021 18:06

Merge branch 'dev' into release/acrchanges

ada05b3

larisaborodina and others added 4 commits August 16, 2021 18:04

Add examples for all the cmdlets.

5f81725

Merge pull request #4 from larisaborodina/release/acrchanges

31a2056

Add examples for all the cmdlets.

Increase vertion to 0.2.0 to avoid clashing with manually released 0.…

55ea749

…1.3 version.

Merge pull request #5 from larisaborodina/release/acrchanges

5c1e28b

Increase vertion to 0.2.0 to avoid clashing with manually released 0.…

bganapa reviewed Aug 18, 2021

View reviewed changes

src/Azs.ContainerRegistry.Admin/readme.md Outdated Show resolved Hide resolved

Merge branch 'Azure:dev' into release/acrchanges

dba2afd

larisaborodina requested a review from bganapa August 19, 2021 00:36

bganapa requested changes Aug 19, 2021

View reviewed changes

src/readme.azurestack.md Outdated Show resolved Hide resolved

bganapa reviewed Aug 19, 2021

View reviewed changes

src/Azs.ContainerRegistry.Admin/examples/Read-AzsContainerRegistry.md Outdated Show resolved Hide resolved

larisaborodina and others added 3 commits August 19, 2021 11:28

Merge branch 'Azure:dev' into release/acrchanges

be23ddd

Replace Read-AzsContainerRegistry to Get-AzsContainerRegistry.

10211aa

Merge pull request #6 from larisaborodina/release/acrchanges

e983df3

Replace Read-AzsContainerRegistry to Get-AzsContainerRegistry.

larisaborodina and others added 5 commits August 23, 2021 11:47

Replace Read-AzsContainerRegistry to Get-AzsContainerRegistry.

617f1f0

Add missed Get-AzsContainerRegistry.Recording.json

34bf575

Add docs for all cmdlets

b78246c

Merge branch 'release/acrchanges' of https://github.com/larisaborodin…

7b24676

…a/azurestack-powershell into release/acrchanges

Merge pull request #9 from larisaborodina/release/acrchanges

7a689a8

ACR Admin module Initial version

larisaborodina and others added 3 commits August 27, 2021 16:17

Merge branch 'Azure:dev' into release/acrchanges

c641788

Fixed tests running locally, updated docs.

f81437a

Merge pull request #10 from larisaborodina/release/acrchanges

36f9520

Fixed tests running locally, updated docs.

larisaborodina dismissed bganapa’s stale review via 36f9520 August 30, 2021 23:21

bganapa changed the title ~~ACR Admin module Initial version~~ ACR Admin module - Pester Test fixes Aug 30, 2021

bganapa and others added 3 commits August 31, 2021 13:29

adding loadEnvJson file for tests

cfa1ba7

Pester Test fixes.

c30c4d8

Merge pull request #11 from larisaborodina/release/acrchanges

810898c

Pester Test fixes

larisaborodina requested a review from bganapa August 31, 2021 23:42

bganapa enabled auto-merge (squash) September 1, 2021 04:00

bganapa approved these changes Sep 1, 2021

View reviewed changes

Merge branch 'Azure:dev' into release/acrchanges

28ef012

bganapa disabled auto-merge September 1, 2021 17:32

bganapa merged commit 39ac2ee into Azure:dev Sep 1, 2021

ACR Admin module - Pester Test fixes #124

ACR Admin module - Pester Test fixes #124

Uh oh!

Conversation

larisaborodina commented Aug 5, 2021

Uh oh!

bganapa commented Aug 9, 2021

Uh oh!

azure-pipelines bot commented Aug 9, 2021

Uh oh!

TheOnlyWei commented Aug 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bganapa commented Aug 18, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bganapa commented Aug 23, 2021

Uh oh!

azure-pipelines bot commented Aug 23, 2021

Uh oh!

bganapa commented Aug 23, 2021

Uh oh!

bganapa commented Aug 30, 2021

Uh oh!

azure-pipelines bot commented Aug 30, 2021

Uh oh!

bganapa commented Sep 1, 2021

Uh oh!

azure-pipelines bot commented Sep 1, 2021

Uh oh!

bganapa commented Sep 1, 2021

Uh oh!

azure-pipelines bot commented Sep 1, 2021

Uh oh!

bganapa commented Sep 1, 2021

Uh oh!

azure-pipelines bot commented Sep 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TheOnlyWei commented Aug 10, 2021 •

edited

Loading