feat: avm/ptn/lz/sub-vending Fixes & Feature for Custom Role Assignment

[ChrisSidebotham]

Description

Closes #4965

Features:

• Enable Custom Role assignments after the subscription move is completed

Fixes:

• Fix for spelling mistake in ExcludedRoles
• Fix for static tests ExcludedRoles > excludedRoles
• Fix for BCP187 Errors under PIM Assignment Types

Pipeline Reference

Pipeline

Type of Change

• Update to CI Environment or utilities (Non-module affecting changes)
• Azure Verified Module updates:
  • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
    • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
    • The bug was found by the module author, and no one has opened an issue to report it yet.
  • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
  • Breaking changes and I have bumped the MAJOR version in version.json.
  • Update to documentation

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• I have run Set-AVMModule locally to generate the supporting module files.
• My corresponding pipelines / checks run clean and green without any errors or warnings

[ReneHezser]

We've just activated automatic checks for the changelog spec BCPNFR22. Please update your branch and add an entry to the CHANGELOG.md.

Sample entry for the CHANGELOG.md in the module directory is:

## 0.2.1

### Changes

- Updated the referenced AVM common types

### Breaking Changes

- None

The new version is calculated automatically, and you must set the new version in the changelog manually. The static tests will show you the expected version if you set it to something else.

SNFR17 - Category: Release - Semantic Versioning

With a new minor version in the version.json, add 0 as patch. If you didn't change the version, the patch will be patch+1.

We are happy to help should you encounter a problem.

[AlexanderSehr]

Hey @ChrisSidebotham, is this still in the works? 😄

[ChrisSidebotham]

@sebassem - Any luck with this?

[sebassem]

@sebassem - Any luck with this?

This is the reply that I got from the ICM

I found this sequence of requests. It might be the case that management group changes are not propagated. So, when you assign the custom role to subscription scope - this scope is not associated with MG scope.
Try adding delay between MG update and role assignment operation.