Skip to content

Conversation

@Dylan-Prins
Copy link

Description

Adding export to types.

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@Dylan-Prins Dylan-Prins requested review from a team as code owners April 18, 2025 08:58
@avm-organizer avm-organizer bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Apr 18, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Apr 18, 2025
@microsoft-github-policy-service

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Apr 18, 2025
@microsoft-github-policy-service

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@Dylan-Prins Dylan-Prins changed the title adding export properties to type definitions for virtual network chore: adding export properties to type definitions for virtual network Apr 18, 2025
@AlexanderSehr
Copy link
Collaborator

Hey @Dylan-Prins,
please excuse the delay. The module owner @mjrich19 should've reviewed your PR, but is maybe out on vacation.
That being said, thank you very much for your contribution. In general, the PR looks good to me. Normally I'd ask you to please also attach a workflow badge that shows hows that the static tests passed, but given the nature of the change it's quite obious that they'll pass.
Regardless, I'd ask one change of you that I'll comment on the files themselves.

Comment on lines +306 to 307
@export()
type peeringType = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@export()
type peeringType = {
@export()
@description('The type of a peering.')
type peeringType = {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this will require you to refresh the main.json again

}

@export()
type subnetType = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type subnetType = {
@description('The type of a subnet.')
type subnetType = {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this will require you to refresh the main.json again

@Dylan-Prins Dylan-Prins closed this by deleting the head repository Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants