Remove SVG export option from visual designer#19302
Merged
Conversation
The html-to-image library uses ForeignObjects for SVG export, which produces low-quality output, and the SVG cleaner has known bugs. - Remove 'svg' from ExportFormat type - Remove SVG from the format dropdown - Remove toSvg import and SVG capture/clean code - Remove ~270 lines of SVG post-processing helpers
levimatheri
approved these changes
Mar 30, 2026
Contributor
|
Test this change out locally with the following install scripts (Action run 23765883933) VSCode
Azure CLI
|
| /* ------------------------------------------------------------------ */ | ||
|
|
||
| const FORMATS: ExportFormat[] = ["svg", "png", "jpeg"]; | ||
| const FORMATS: ExportFormat[] = ["png", "jpeg"]; |
Member
There was a problem hiding this comment.
Personally I would vote for "png" and "png (no background)", rather than giving "jpg" as an option.
Jpg is a lossy format, and IMO isn't as relevant today for non-photograph content - compression doesn't matter so much, browser/OS support is good for png.
Contributor
Author
There was a problem hiding this comment.
Yeah, that makes sense. I was planning to put this in a separate PR since it requires some UI design changes for the export toolbar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The html-to-image library relies on
foreignObjectfor SVG export, which largely defeats the purpose of using SVG. This PR removes SVG export support altogetherChanges
svgfromExportFormattype (nowpng | jpeg)ExportToolbartoSvgimport and thesvgcapture casesvgentries fromFORMAT_MIME/FORMAT_DESC