Warn for string-to-literal narrowing assignments#19603
Open
polatengin wants to merge 3 commits intomainfrom
Open
Warn for string-to-literal narrowing assignments#19603polatengin wants to merge 3 commits intomainfrom
polatengin wants to merge 3 commits intomainfrom
Conversation
Contributor
|
Test this change out locally with the following install scripts (Action run 25392104965) VSCode
Azure CLI
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows assignments from plain
stringvalues to fixed string-literal receivers, such as'foo' | 'bar', to compile with a warning when the value may be valid at runtime.The assignment is treated as narrowed to the receiver’s allowed string literals, matching existing narrowing behavior for bounded values.
Fixes #11889
Example Usage
This now emits warning-level
BCP036instead of error-levelBCP036Checklist
Microsoft Reviewers: Open in CodeFlow