Allow string literals in object property names#275
Merged
Conversation
Collaborator
|
We should also update the list of known issues in the readme which discusses this issue |
Member
Author
Will do |
majastrz
reviewed
Aug 20, 2020
Member
majastrz
reviewed
Aug 20, 2020
anthony-c-martin
force-pushed
the
antmarti/stringprops
branch
from
d556562 to
26aa76e
Compare
| public static string AddDiagsToSourceText<T>(DataSet dataSet, IEnumerable<T> items, Func<T, TextSpan> getSpanFunc, Func<T, string> diagsFunc) | ||
| { | ||
| var lineStarts = TextCoordinateConverter.GetLineStarts(sourceText); | ||
| var newlineSequence = dataSet.HasCrLfNewlines() ? "\r\n" : "\n"; |
Member
Author
There was a problem hiding this comment.
I was writing back these files using StringBuilder.AppendLine, which uses different newline terminators depending on the platform (hence the huge diffs...). This will make it consistent cross-platform and avoid the huge diffs occurring again (sorry!).
Member
There was a problem hiding this comment.
Better now than later. Btw, CodeFlow shows "Edit" but no actual diff :)
In reply to: 474407770 [](ancestors = 474407770)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #249
Closes #145
Closes #156
Closes #206