Upgrade Sql Client to 5.0.1 #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Service.Tests/Authorization/GraphQL/GraphQLMutationAuthorizationTests.cs
Show resolved
Hide resolved
Contributor
|
If Abhishek's suggestion does not eliminate the need to refactor, make sure to include that information (what you tried, why the refactor is necessary) in your PR description for when you move it out of draft. |
Aniruddh25
requested review from
Aniruddh25,
JelteF,
Mathos1432,
gledis69,
jarupatj,
mbhaskar,
milismsft and
seantleonard
as code owners
Aniruddh25
requested review from
aaronpowell,
ayush3797,
junsu0ms,
ravishetye,
severussundar and
tarazou9
as code owners
Aniruddh25
approved these changes
Dec 9, 2022
seantleonard
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #911
What is this change?
In
Directory.Packages.Propswe update the SQL Client version to 5.0.1This is the most up to date version, and the current SQL Client version we use is not longer supported.
This creates a large number of namespace collisions in our project with
Azure.Operation, most of which are fixed by usingConfig.Operationinstead ofOperation.We tried
using Operation = Azure.DataApiBuilder.Config.Operationbut this fails to resolve the collisions.How was this tested?
Ran against existing test suite.
Sample Request(s)
No change to service, can run as normal.