Upgrade Sql Client to 4.1.1 #924
Conversation
aaronburtle
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
jarupatj,
junsu0ms,
mbhaskar,
milismsft,
seantleonard,
severussundar and
tarazou9
as code owners
ConfigGenerators/MsSqlCommands.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| init --config "dab-config.MsSql.json" --database-type mssql --connection-string "Server=tcp:127.0.0.1,1433;Persist Security Info=False;User ID=sa;Password=REPLACEME;MultipleActiveResultSets=False;Connection Timeout=5;" --host-mode Development --authenticate-devmode-requests false --cors-origin "http://localhost:5000" | |||
| init --config "dab-config.MsSql.json" --database-type mssql --connection-string "Server=tcp:127.0.0.1,1433;Persist Security Info=False;User ID=sa;Password=REPLACEME;MultipleActiveResultSets=False;Connection Timeout=5;Encrypt=False;" --host-mode Development --authenticate-devmode-requests false --cors-origin "http://localhost:5000" | |||
There was a problem hiding this comment.
Reason for this change? perhaps accidental?
There was a problem hiding this comment.
trying to debug the connection issue that mssql was having after the update. Found an article that indicated the problem may be 4.0+ defaulting to encryption. The solution for that problem is to add this Encrypt=False to the connection string, which works fine locally for me as well, but is breaking the ConfigGenerator.sh script.
There was a problem hiding this comment.
For MsSql Integration tests, the value specified in this file does not matter. The FileTransformTask that runs before the integration test replaces it with the value set in the pipeline variable. Adding Encrypt=False to the pipeline variable could be worth a try.
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
let me know if any other changes occur so i can review/approve.
.pipelines/mssql-pipelines.yml
Outdated
| condition: eq( variables['Agent.OS'], 'Linux' ) | ||
| displayName: Get and Start Ubuntu SQL Server Image Docker | ||
| env: | ||
| DockerSQLpass: foo |
There was a problem hiding this comment.
I believe DockerSQLpass is also a pipeline variable that can be set when you set the connection string. Let's try setting both in the pipeline variables. We should not harcode the password in the yml.
…ub.com/Azure/hawaii-gql into dev/aaronburtle/UpdateSqlClientVersion
|
I see a PR: Upgrading Sql CLient to 5.0.1, |
Once I confirm I can get 5.0.1 working I will close this, otherwise, we will use 4.1.1 as a temporary fix. |
Why make this change?
Closes #911
Sql Client 3.0 is out of support, so we upgrade to 4.1.1
What is this change?
In
Directory.Build.Propswe change the Sql Version to 4.1.1How was this tested?
Ran against current test suite.
Sample Request(s)
Start and run engine as normal.