Skip to content

Use ILogger to print CLI logs #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abhishekkumams merged 15 commits into from
Dec 27, 2022
Merged

Use ILogger to print CLI logs #1039

abhishekkumams merged 15 commits into from
Dec 27, 2022

Conversation

@abhishekkumams
Copy link
Contributor

@abhishekkumams abhishekkumams commented Dec 13, 2022 •
edited
Loading

Why make this change?

What is this change?

  • Adding a new class for custom logging.
  • Custom Logging because the original one prints extra info (like class name).
  • Color combinantion.
    image

How was this tested?

manually

Sample Request(s)

image

@abhishekkumams abhishekkumams linked an issue Dec 13, 2022 that may be closed by this pull request
Standardize the Logging system for CLI with that of engine #870
Closed
@abhishekkumams abhishekkumams changed the title Dev/abhishekkuma/standardize cli logging Use ILogger to print CLI logs Dec 13, 2022
jarupatj
jarupatj previously requested changes Dec 13, 2022
View reviewed changes
seantleonard
seantleonard previously requested changes Dec 13, 2022
View reviewed changes
severussundar
severussundar reviewed Dec 14, 2022
View reviewed changes
severussundar
severussundar reviewed Dec 14, 2022
View reviewed changes
@abhishekkumams abhishekkumams self-assigned this Dec 20, 2022
@abhishekkumams abhishekkumams added this to the Jan2023 milestone Dec 20, 2022
@abhishekkumams abhishekkumams dismissed stale reviews from seantleonard and jarupatj December 23, 2022 03:32

updated

ravishetye
ravishetye reviewed Dec 26, 2022
View reviewed changes
@abhishekkumams
Merge branch 'main' of https://github.com/Azure/data-api-builder into…
3c56339 
… dev/abhishekkuma/standardize-cli-logging
@abhishekkumams abhishekkumams merged commit 9b96cf6 into main Dec 27, 2022
@abhishekkumams abhishekkumams deleted the dev/abhishekkuma/standardize-cli-logging branch December 27, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@Aniruddh25 Aniruddh25 Awaiting requested review from Aniruddh25 Aniruddh25 is a code owner

@JelteF JelteF Awaiting requested review from JelteF

@Mathos1432 Mathos1432 Awaiting requested review from Mathos1432

@gledis69 gledis69 Awaiting requested review from gledis69

@aaronburtle aaronburtle Awaiting requested review from aaronburtle aaronburtle is a code owner

@milismsft milismsft Awaiting requested review from milismsft

@junsu0ms junsu0ms Awaiting requested review from junsu0ms

@tarazou9 tarazou9 Awaiting requested review from tarazou9

@aaronpowell aaronpowell Awaiting requested review from aaronpowell

@jarupatj jarupatj Awaiting requested review from jarupatj

@seantleonard seantleonard Awaiting requested review from seantleonard

@severussundar severussundar Awaiting requested review from severussundar

2 more reviewers

@ravishetye ravishetye ravishetye approved these changes

@ayush3797 ayush3797 ayush3797 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abhishekkumams abhishekkumams

Labels

cli

Projects

Data API builder
Status: Done

Milestone

Jan2023

Development

Successfully merging this pull request may close these issues.

Standardize the Logging system for CLI with that of engine

7 participants

@abhishekkumams @jarupatj @ravishetye @seantleonard @severussundar @ayush3797