Skip to content

Conversation

@abhishekkumams
Copy link
Contributor

@abhishekkumams abhishekkumams commented Jan 27, 2023

Why make this change?

What is this change?

  • Added a new build pipeline task to publish the nuget package to external feed nuget.org.
  • This task will only run when the pipeline runs with isNugetRelease set to true.

How was this tested?

  • Passing Pipeline
  • Going to Nuget.org to verify
  • Steps:
    1. Created a test package (It's a demo package which only prints hello world).
    2. Added it to the repo and commented out all the build steps other than (code signing, and publishing) to speed things up.
    3. Successfully published it through ADO pipeline with ID Microsoft.DataApiBuilder.Test, and I was able to successfully publish to nuget.org. Link: https://www.nuget.org/packages/Microsoft.DataApiBuilder.Test/

Reference Links

Publish NuGet packages with Pipeline tasks or the classic editor - Azure Pipelines | Microsoft Learn.

Updates

  1. Facing issue with Reserved Namespace, Microsoft.DataApiBuilder.*, due to which we are unable to upload package with ID Microsoft.DataApiBuilder, whereas Microsoft.DataApiBuilder.Test works fine. There is an ongoing mail thread to update the regex for reserved namespace given to DataApiBuilder. Once we get an update on that I will update this PR.

@seantleonard
Copy link
Contributor

the nuget page*

@abhishekkumams
Copy link
Contributor Author

Is this page public? do we want this published prior to announcement of public preview?

Yes, this page is public. But, we have only uploaded the test package which contains nothing.

@abhishekkumams abhishekkumams marked this pull request as ready for review January 31, 2023 15:14
Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the regex for the reserved prefix has been modified, LGTM after resolving the comments.

@abhishekkumams abhishekkumams merged commit ca580d3 into main Feb 1, 2023
@abhishekkumams abhishekkumams deleted the dev/abhishekkuma/publish_dab_nuget_to_nuget_org branch February 1, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish NuGet package www.nuget.org

4 participants