Obtaining cosmos Database name from connection string #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o connection string.
mbhaskar
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
jarupatj,
junsu0ms,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
tarazou9
approved these changes
Jan 27, 2023
Aniruddh25
reviewed
Jan 27, 2023
Aniruddh25
approved these changes
Jan 27, 2023
seantleonard
approved these changes
Jan 30, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
lgtm, assuming Ani's suggestion is addressed
tarazou9
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
SWA may append the database name for the cosmos to the connection string. This PR lets the engine parse the db name from connection string for Cosmos DB
Fixes #1119
How was this tested?
Sample Request(s)
Example connection string
"AccountEndpoint=https://localhost:8081/;AccountKey=key;Database=gql_db"