-
Notifications
You must be signed in to change notification settings - Fork 298
fixing logs for add command #1148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
abhishekkumams
merged 5 commits into
main
from
dev/abhishekkuma/missing-configuration-file-name-in-printed-message
Feb 1, 2023
Merged
fixing logs for add command #1148
abhishekkumams
merged 5 commits into
main
from
dev/abhishekkuma/missing-configuration-file-name-in-printed-message
Feb 1, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayush3797
reviewed
Jan 31, 2023
ayush3797
approved these changes
Jan 31, 2023
seantleonard
previously requested changes
Jan 31, 2023
Contributor
seantleonard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
…name-in-printed-message
Aniruddh25
approved these changes
Jan 31, 2023
…name-in-printed-message
Aniruddh25
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
addcommand.config:, but it doesn't print anything when the user doesn't provide it in the options. This is an inconsistent behavior.What is this change?
What was the root cause?
options.configwas empty and hence the config name was not getting printed.How was this tested?
Sample Request(s)
dab add MyEntity -s my_entity --permissions "anonymous:*"