Fixing build warnings #1160
Merged
Fixing build warnings #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ayush3797
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
gledis69,
junsu0ms,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Aniruddh25
reviewed
Feb 1, 2023
Aniruddh25
reviewed
Feb 1, 2023
Aniruddh25
reviewed
Feb 1, 2023
Aniruddh25
reviewed
Feb 1, 2023
abhishekkumams
approved these changes
Feb 1, 2023
seantleonard
reviewed
Feb 1, 2023
seantleonard
reviewed
Feb 1, 2023
seantleonard
reviewed
Feb 1, 2023
seantleonard
reviewed
Feb 1, 2023
seantleonard
reviewed
Feb 1, 2023
seantleonard
reviewed
Feb 1, 2023
seantleonard
reviewed
Feb 1, 2023
seantleonard
reviewed
Feb 1, 2023
seantleonard
reviewed
Feb 1, 2023
seantleonard
reviewed
Feb 1, 2023
added 2 commits
February 1, 2023 23:57
seantleonard
reviewed
Feb 1, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
httpstatuscode should be consistent with code sent for other config validation issues. Don't use the authorization forbidden return code
Aniruddh25
reviewed
Feb 1, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Lets fail the build if warnings exist. So, in future, warnings are not overlooked
Aniruddh25
approved these changes
Feb 1, 2023
seantleonard
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Fix build warnings: #1156.
Additional change
Failing build if there are warnings.
How was this tested?
Not required.