Notice Generation Script - CR LF Correction#1298
Merged
seantleonard merged 3 commits intomainfrom Mar 2, 2023
Merged
Conversation
…r better performance than get-content and set-content
seantleonard
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
junsu0ms,
mbhaskar,
milismsft,
ravishetye,
severussundar and
tarazou9
as code owners
aaronburtle
approved these changes
Mar 2, 2023
Contributor
aaronburtle
left a comment
aaronburtle
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fast fix!
Aniruddh25
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
(c) Microsoft 2023copyright from notice file with corrected detection of CR LF in the file generated, not just LF:What is this change?
(c) Microsoft 2023:.Replace("(c) Microsoft 2023rn", "")[System.IO.File]instead ofGet-ContentandSet-Contentper https://stackoverflow.com/a/30893960/18174950How was this tested?
Job/nupkg/Microsoft.DataApiBuilder..nupkg Nupkg contains NOTICE.txt with concatenated license. To validate nupkg, rename the downloaded file to use the file extension .zip, and then you can browse contents.
local test
Add new directory with files
C:\InputsRun powershell script: .\notice-generation.ps1 C:\Inputs C:\Inputs
param1: $BuildArtifactStagingDir (would be location to save the downloaded license)
param2: $BuildSourcesDir (would contain the notice.txt)