Add check for graphql schema file availibility for CosmosDB#1314
Merged
abhishekkumams merged 33 commits intomainfrom Mar 20, 2023
Merged
Add check for graphql schema file availibility for CosmosDB#1314abhishekkumams merged 33 commits intomainfrom
abhishekkumams merged 33 commits intomainfrom
Conversation
abhishekkumams
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
ayush3797,
gledis69,
junsu0ms,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Aniruddh25
reviewed
Mar 11, 2023
Aniruddh25
reviewed
Mar 11, 2023
… dev/abhishekkuma/add_cosmosdb_no_schemafile_check
…ttps://github.com/Azure/data-api-builder into dev/abhishekkuma/add_cosmosdb_no_schemafile_check
…ttps://github.com/Azure/data-api-builder into dev/abhishekkuma/add_cosmosdb_no_schemafile_check
ayush3797
approved these changes
Mar 20, 2023
abhishekkumams
deleted the
dev/abhishekkuma/add_cosmosdb_no_schemafile_check
branch
abhishekkumams
added a commit
that referenced
this pull request
Mar 30, 2023
## Why make this change? - Closes #826 - Config is generated even when specified graphQL schema file is not available/present. ## What is this change? - Adding a check to see if the specified schema file is available in case of CosmosDB ## How was this tested? - [X] Unit Tests ## Additional Some refactoring work --------- Co-authored-by: Ayush Agarwal <34566234+ayush3797@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
How was this tested?
Additional
Some refactoring work