Make key fields mandatory for adding/updating views in CLI#1368
Merged
abhishekkumams merged 28 commits intomainfrom Mar 31, 2023
Merged
Conversation
… dev/abhishekkuma/making_keyFields_mandatory_forp_views_in_cli
abhishekkumams
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
ayush3797,
gledis69,
junsu0ms,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
abhishekkumams
changed the title
ayush3797
reviewed
Mar 28, 2023
ayush3797
approved these changes
Mar 28, 2023
seantleonard
previously requested changes
Mar 29, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
looks good so far, pending tests/documentation to add before merge.
Aniruddh25
reviewed
Mar 29, 2023
… dev/abhishekkuma/making_keyFields_mandatory_forp_views_in_cli
…in_cli' of https://github.com/Azure/data-api-builder into dev/abhishekkuma/making_keyFields_mandatory_forp_views_in_cli
…forp_views_in_cli
…in_cli' of https://github.com/Azure/data-api-builder into dev/abhishekkuma/making_keyFields_mandatory_forp_views_in_cli
…forp_views_in_cli
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
need additional result checking for GraphQL request in your mssql view test. otherwise looks good. thank you for addressing comments.
Aniruddh25
reviewed
Mar 30, 2023
Aniruddh25
approved these changes
Mar 30, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
LGTM, after the graphql response check
…forp_views_in_cli
…in_cli' of https://github.com/Azure/data-api-builder into dev/abhishekkuma/making_keyFields_mandatory_forp_views_in_cli
abhishekkumams
deleted the
dev/abhishekkuma/making_keyFields_mandatory_forp_views_in_cli
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
How was this tested?
Sample Request(s)
Adding a view without KeyFields
Adding a view with KeyFields
Updating a table to view without KeyFields
Updating a table to view with KeyFields
NOTE:
Engine will continue to support config with views that do not have key-fields provided in the config. This Validation is only applicable when adding/updating views through CLI.