Skip to content

Test config precedence over db relationship#1396

Merged
abhishekkumams merged 29 commits intomainfrom
dev/abhishekkuma/test_config_precedence_over_db_relationship
Apr 3, 2023
Merged

Test config precedence over db relationship#1396
abhishekkumams merged 29 commits intomainfrom
dev/abhishekkuma/test_config_precedence_over_db_relationship

Conversation

@abhishekkumams
Copy link
Contributor

@abhishekkumams abhishekkumams commented Mar 31, 2023 •
edited
Loading

Why make this change?

What is this change?

  • Adding a test consisting of two tables players and clubs, where the players table contain a coulmns like current_club_id and new_club_id. current_club_id is used as foriegn key for relationship with table clubs.
  • The test verifies the differnece how providing source fields as new_club_id and target field as id in the config, overrrides the original relationship fields between players and clubs.

How was this tested?

  • Integration Tests

@abhishekkumams abhishekkumams marked this pull request as draft March 31, 2023 10:26
@abhishekkumams abhishekkumams self-assigned this Apr 1, 2023
@abhishekkumams abhishekkumams added this to the Mar2023 milestone Apr 1, 2023
@abhishekkumams abhishekkumams marked this pull request as ready for review April 2, 2023 09:28
Aniruddh25
Aniruddh25 approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test! LGTM after resolving comments

@abhishekkumams abhishekkumams enabled auto-merge (squash) April 3, 2023 04:47
@abhishekkumams abhishekkumams merged commit f35fcff into main Apr 3, 2023
@abhishekkumams abhishekkumams deleted the dev/abhishekkuma/test_config_precedence_over_db_relationship branch April 3, 2023 05:40
@ayush3797 ayush3797 restored the dev/abhishekkuma/test_config_precedence_over_db_relationship branch April 3, 2023 06:53
@abhishekkumams abhishekkumams deleted the dev/abhishekkuma/test_config_precedence_over_db_relationship branch April 19, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aniruddh25 Aniruddh25 Aniruddh25 approved these changes

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@JelteF JelteF Awaiting requested review from JelteF

@seantleonard seantleonard Awaiting requested review from seantleonard

@Mathos1432 Mathos1432 Awaiting requested review from Mathos1432

@gledis69 gledis69 Awaiting requested review from gledis69

@aaronburtle aaronburtle Awaiting requested review from aaronburtle aaronburtle is a code owner

@milismsft milismsft Awaiting requested review from milismsft

@junsu0ms junsu0ms Awaiting requested review from junsu0ms

@tarazou9 tarazou9 Awaiting requested review from tarazou9

@aaronpowell aaronpowell Awaiting requested review from aaronpowell

@severussundar severussundar Awaiting requested review from severussundar

@ravishetye ravishetye Awaiting requested review from ravishetye

+1 more reviewer

@ayush3797 ayush3797 ayush3797 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abhishekkumams abhishekkumams

Labels

test

Projects

Data API builder
Status: Done

Milestone

Mar2023

Development

Successfully merging this pull request may close these issues.

add a new test to see when either sourceFields or targetFields is NOT NULL AND Foreign Key is ALSO present

3 participants

@abhishekkumams @Aniruddh25 @ayush3797