Add support for datetimeoffset MsSql data type#1400
Merged
Aniruddh25 merged 9 commits intomainfrom Apr 3, 2023
Merged
Conversation
Aniruddh25
requested review from
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
junsu0ms,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
…pi-builder into fixDateColumnOffset
…meOffset as a System.Type to accommodate the range
seantleonard
reviewed
Apr 1, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Looks good so far, is there any way to add 1 test for e2e REST request with this new datatype?
Collaborator
Author
There is an existing issue to add new tests for REST - #662 for additional supported types |
seantleonard
reviewed
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
by considering this case in the EdmModelBuilder and SchemaConverter.
What is this change?
DateTimeOffsetwhile converting fromSystemTypetoEdmPrimitiveTypeKind.DateTimeOffsetis simplyDateTimein HotChocolate.Types used in SchemaConverter.DateTimeOffsetcase to Param creation.How was this tested?
datetimeoffsetin MsSql to test this. Also added columns fordatetime2,date,smalldatetimeto ensure those are already supported