Use System.CommandLine to Parse Command Line Args#1405
Merged
aaronburtle merged 15 commits intomainfrom Apr 3, 2023
Merged
Conversation
aaronburtle
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
junsu0ms,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
…m/Azure/data-api-builder into dev/aaronburtle/SystemCommandLine
abhishekkumams
approved these changes
Apr 3, 2023
Contributor
abhishekkumams
left a comment
abhishekkumams
left a comment
There was a problem hiding this comment.
LGTM, thanks for quickly addressing the changes.
seantleonard
reviewed
Apr 3, 2023
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
…m/Azure/data-api-builder into dev/aaronburtle/SystemCommandLine
seantleonard
approved these changes
Apr 3, 2023
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Thank you for updating the log level parsing mechanism!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #860
What is this change?
We add
System.CommandLineto the project, and leverage its command line parser to do the parsing of command line args for log level. We should not need to write our own parser, and this change aligns us more closely with the .NET CLI.How was this tested?
Manually tested and run against our test suite.
Sample Request(s)
Easiest way to test is to run the service through the CLI. You can also modify the code in program to have any custom string array and pass that to the parsing function.