Allow passing a config override file through the configuration endpoint.#1452
Merged
Mathos1432 merged 11 commits intomainfrom May 12, 2023
Merged
Allow passing a config override file through the configuration endpoint.#1452Mathos1432 merged 11 commits intomainfrom
Mathos1432 merged 11 commits intomainfrom
Conversation
Mathos1432
force-pushed
the
user/matrembl/configv2
branch
2 times, most recently
from
c6c26ce to
68b6925
Compare
Mathos1432
force-pushed
the
user/matrembl/configv2
branch
from
68b6925 to
2bb4c0f
Compare
Mathos1432
force-pushed
the
user/matrembl/configv2
branch
from
2bb4c0f to
2cf5181
Compare
Mathos1432
added
hosting
config
Mathos1432
requested review from
Aniruddh25,
JelteF,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
Mathos1432
changed the title
Aniruddh25
reviewed
May 11, 2023
Aniruddh25
reviewed
May 11, 2023
Aniruddh25
reviewed
May 11, 2023
Aniruddh25
reviewed
May 11, 2023
Aniruddh25
reviewed
May 11, 2023
Aniruddh25
approved these changes
May 11, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Thank you getting this change in so quickly after the config-merge feature was added! LGTM, left a few questions.
mbhaskar
reviewed
May 12, 2023
Aniruddh25
reviewed
May 12, 2023
| } | ||
| } | ||
|
|
||
| private static string GenerateMockJwtToken() |
Collaborator
There was a problem hiding this comment.
JwtTokenAuthenticationUnitTests.cs has a similar CreateJwt() function. Could you reuse that here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
We want to be able to provide the configuration file and a set of overrides when configuring the engine at runtime. This will allow us to override any existing or new setting without requiring an other update to the configuration endpoint.
closes #1484
What is this change?
How was this tested?
Remaining work