ExecuteEntityTool: DB metadata based parameter support#3600
Open
souvikghosh04 wants to merge 7 commits into
Open
ExecuteEntityTool: DB metadata based parameter support#3600souvikghosh04 wants to merge 7 commits into
souvikghosh04 wants to merge 7 commits into
Conversation
3 tasks
anushakolan
reviewed
May 19, 2026
Aniruddh25
reviewed
May 20, 2026
Aniruddh25
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
ExecuteEntityToolvalidated parameters against config-sideSource.Parametersonly, rejecting DB-discovered parameters that had no config entry. Defaults were applied in an all-or-nothing fashion (only when the user supplied zero parameters).What is this change?
StoredProcedureDefinition.Parameters(the merged DB metadata) as source of truth, accepting any parameter the DB declares.ParameterDefinition.HasConfigDefault/ConfigDefaultValueper-missing-parameter, so partial user input gets remaining defaults filled in. This is an intentional behavioral change from the previous all-or-nothing guard.dbObjecttoDatabaseStoredProcedurewith graceful error instead of unconditional cast.How was this tested?
AcceptsDbDiscoveredParamRejectsInvalidParamName(x2)AcceptsMultipleValidParamsRejectsRequest_WhenAnyParamInvalidAppliesConfigDefaultsHasConfigDefault/ConfigDefaultValueUserParamsOverrideDoesNotInjectWithoutDefaultHasConfigDefaultis not injectedZeroParamSPRejectsNonStoredProcedureEntityReturnsError_WhenEntityNotFoundGetBookById_ReturnsRecordInsertBookWithDefaults_ExecutesSuccessfullySample Request(s)
NA