Cherry-Pick: Add changes to fix Nuget Core Package Creation#3633
Merged
Aniruddh25 merged 2 commits intoMay 22, 2026
Conversation
## Why make this change? - Solves issue #3607 Currently the notice file script has a bug that causes it to not replace some of the strings correctly as the values in the `content` variable that are replaced are overwritten by other changes, so they are not saved. ## What is this change? Changed the way the values are changed inside the `content` value by using regex. Currently the only values that need to be deleted are for the years 2023 and 2024. This might change in the future. ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests - [x] Manual Testing Tested this manually by running the script locally. ## Sample Request(s) N/A --------- Co-authored-by: aaronburtle <93220300+aaronburtle@users.noreply.github.com>
## Why make this change? - Solves issue #3618 ## What is this change? This adds `TargetsForTfmSpecificContentInPackage` and `IncludeInternalDependenciesInPackage` to create the dependencies from the Core project as dlls. And uses the `PrivateAssets` to ensure that those dependencies are not added to the nuspec file. ## How was this tested? - [ ] Integration Tests - [ ] Unit Tests - [X] Manual Tests Tested by using command `dotnet pack .\Azure.DataApiBuilder.Core.csproj -c Release` to build nuget package and ensure that all the dependencies are created as expected. <img width="828" height="355" alt="image" src="https://github.com/user-attachments/assets/cb3a72c1-1984-4869-aece-4f1d17bc7519" /> ## Sample Request(s) N/A --------- Co-authored-by: Aniruddh Munde <anmunde@microsoft.com> Co-authored-by: aaronburtle <93220300+aaronburtle@users.noreply.github.com>
RubenCerna2079
requested review from
Alekhya-Polavarapu,
Aniruddh25,
JerryNixon,
aaronburtle,
anushakolan,
rusamant,
sourabh1007,
souvikghosh04,
stuartpa and
vadeveka
as code owners
RubenCerna2079
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Cherry-picks upstream fixes to ensure the Microsoft.DataApiBuilder.Core NuGet package is produced with the expected internal assemblies bundled, and corrects the NOTICE generation script so erroneous copyright lines are reliably removed.
Changes:
- Updates
Azure.DataApiBuilder.Core.csprojpack process to include internal dependency DLLs underlib/<tfm>. - Updates
notice-generation.ps1to use a regex-based replacement to remove incorrect year lines.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Core/Azure.DataApiBuilder.Core.csproj | Adds a pack-time target to include internal dependency DLLs and adjusts project reference metadata intended to control nuspec dependency output. |
| scripts/notice-generation.ps1 | Fixes NOTICE file cleanup logic by replacing a fragile sequence of ReadAllText().Replace(...) calls with a single regex replacement. |
aaronburtle
approved these changes
May 22, 2026
Aniruddh25
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
This change cherry-picks the PRs that fixes the new Nuget Core Package
What is this change?
Cherry-picked PRs
How was this tested?
Existing tests in cherry-pick cover new changes.
Sample Request(s)
N/A